Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3002)

Unified Diff: build/temp_gyp/googleurl.gyp

Issue 6538022: Switch the build over to using the base test runner to make sure... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/googleurl.gyp
===================================================================
--- build/temp_gyp/googleurl.gyp (revision 75303)
+++ build/temp_gyp/googleurl.gyp (working copy)
@@ -70,6 +70,8 @@
'target_name': 'googleurl_unittests',
'dependencies': [
'googleurl',
+ '../../base/base.gyp:base_i18n',
+ '../../base/base.gyp:test_support_base',
Robert Sesek 2011/02/17 21:44:22 Was the issue here missing symbols that was causin
TVL 2011/02/17 21:52:51 So the problem was the unittest only started up gt
'../../testing/gtest.gyp:gtest',
'../../third_party/icu/icu.gyp:icuuc',
],
@@ -79,7 +81,9 @@
'../../googleurl/src/url_parse_unittest.cc',
'../../googleurl/src/url_test_utils.h',
'../../googleurl/src/url_util_unittest.cc',
- '../../googleurl/src/gurl_test_main.cc',
+ # Make sure base and ICU are started up the 'Chromium way' since the
+ # build is using the Chromium base & ICU.
+ '../../base/test/run_all_unittests.cc',
],
'conditions': [
['OS=="linux" or OS=="freebsd"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698