Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 6538021: Revert 75263 - Revert 75188 - Revert 75184 - Move googleurl's unittest to use... (Closed)

Created:
9 years, 10 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 75263 - Revert 75188 - Revert 75184 - Move googleurl's unittest to use a custom main so ICU can be started up in a way that matches the Chromium build. Review URL: http://codereview.chromium.org/6532003 TBR=thomasvl@chromium.org Review URL: http://codereview.chromium.org/6507022 TBR=rsesek@chromium.org TBR=thomasvl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M build/temp_gyp/googleurl.gyp View 2 chunks +1 line, -2 lines 0 comments Download
D build/temp_gyp/googleurl_test_main.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
9 years, 10 months ago (2011-02-17 15:39:21 UTC) #1
TVL
9 years, 10 months ago (2011-02-17 15:46:23 UTC) #2
lg

Powered by Google App Engine
This is Rietveld 408576698