Issue 6532003: Move googleurl's unittest to use a custom main so ICU can be started up in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6532003: Move googleurl's unittest to use a custom main so ICU can be started up in... (Closed)

Created:
9 years, 10 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move googleurl's unittest to use a custom main so ICU can be started up in a way that matches the Chromium build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75184

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	build/temp_gyp/googleurl.gyp	View		2 chunks	+2 lines, -1 line	0 comments	Download
	A	build/temp_gyp/googleurl_test_main.cc	View		1 chunk	+22 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

9 years, 10 months ago (2011-02-16 21:31:33 UTC) #2

LGTM

http://codereview.chromium.org/6532003/diff/1/build/temp_gyp/googleurl_test_m...
File build/temp_gyp/googleurl_test_main.cc (right):

http://codereview.chromium.org/6532003/diff/1/build/temp_gyp/googleurl_test_m...
build/temp_gyp/googleurl_test_main.cc:7: // how the Chromium tree expects which
is different then what is in the
than

http://codereview.chromium.org/6532003/diff/1/build/temp_gyp/googleurl_test_m...
build/temp_gyp/googleurl_test_main.cc:17: ::testing::InitGoogleTest(&argc,
argv);
Why is this one fully-qualified with the :: up front, while everything else in
here isn’t?

Expand Messages | Collapse Messages