Add access checks to Object.preventExtensions + add regression test for 1027....

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc	(revision 6829)
+++ test/cctest/test-api.cc	(working copy)
@@ -5652,8 +5652,7 @@
 }
 
 
-// This is a regression test for issue 1154.
-TEST(AccessControlObjectKeys) {
+TEST(AccessControlES5) {
   v8::HandleScope handle_scope;
   v8::Handle<v8::ObjectTemplate> global_template = v8::ObjectTemplate::New();
 
@@ -5677,7 +5676,33 @@
   v8::Handle<v8::Object> global1 = context1->Global();
   global1->Set(v8_str("other"), global0);
 
+  // Regression test for issue 1154.
   ExpectTrue("Object.keys(other).indexOf('blocked_prop') == -1");
+
+  ExpectUndefined("other.blocked_prop");
+
+  // Regression test for issue 1027.
+  ExpectUndefined(
+      "Object.defineProperty("

[antonm, 2011/02/17 15:44:12]

feel free to ignore: I would group lines into something like 

"Object.defineProperty(\n"
"  other, 'blocked_prop', { configurable: false}).blocked_prop")

because for me C's " really stand in the way, esp. for "'blocked_prop'"

But if you find your version more readable, that's perfectly ok

[Rico, 2011/02/18 07:49:09]

Done.

+          "other,"
+          "'blocked_prop',"
+          "{configurable: false}"
+      ").blocked_prop");

[antonm, 2011/02/17 15:44:12]

might be slightly easier for people not that experienced in defineProperty if
split into two parts:

Object.defineProperty(other, 'blocked_prop', ....);
other.blocked_prop

[Rico, 2011/02/18 07:49:09]

Done.

+  ExpectUndefined(
+      "Object.getOwnPropertyDescriptor(other, 'blocked_prop')");
+
+  // Regression test for issue 1171.
+  ExpectTrue("Object.isExtensible(other)");
+  CompileRun("Object.preventExtensions(other)");
+  ExpectTrue("Object.isExtensible(other)");
+
+  // Seal and freeze uses other functions which already includes access

[antonm, 2011/02/17 15:44:12]

function[s] hence include with not s, correct?

[Rico, 2011/02/18 07:49:09]

Changed comment 

+  // checks, but we check these anyway.

[antonm, 2011/02/17 15:44:12]

and maybe you can just drop this comment

[Rico, 2011/02/18 07:49:09]

Done.

+  CompileRun("Object.freeze(other)");
+  ExpectTrue("Object.isExtensible(other)");
+
+  CompileRun("Object.seal(other)");
+  ExpectTrue("Object.isExtensible(other)");
 }