Add access checks to Object.preventExtensions + add regression test for 1027....

test/cctest/test-api.cc

 // Copyright 2007-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5634 matching lines @@
                  "return true;})()");
   CHECK(value->IsTrue());
 
   context1->Exit();
   context0->Exit();
   context1.Dispose();
   context0.Dispose();
 }
 
 
-// This is a regression test for issue 1154.
-TEST(AccessControlObjectKeys) {
+TEST(AccessControlES5) {
   v8::HandleScope handle_scope;
   v8::Handle<v8::ObjectTemplate> global_template = v8::ObjectTemplate::New();
 
   global_template->SetAccessCheckCallbacks(NamedAccessBlocker,
                                            IndexedAccessBlocker);
 
   // Add an accessor that is not accessible by cross-domain JS code.
   global_template->SetAccessor(v8_str("blocked_prop"),
                                UnreachableGetter, UnreachableSetter,
                                v8::Handle<Value>(),
                                v8::DEFAULT);
 
   // Create an environment
   v8::Persistent<Context> context0 = Context::New(NULL, global_template);
   context0->Enter();
 
   v8::Handle<v8::Object> global0 = context0->Global();
 
   v8::Persistent<Context> context1 = Context::New();
   context1->Enter();
   v8::Handle<v8::Object> global1 = context1->Global();
   global1->Set(v8_str("other"), global0);
 
+  // Regression test for issue 1154.
   ExpectTrue("Object.keys(other).indexOf('blocked_prop') == -1");
+
+  ExpectUndefined("other.blocked_prop");
+
+  // Regression test for issue 1027.
+  ExpectUndefined(
+      "Object.defineProperty("

[antonm, 2011/02/17 15:44:12]

feel free to ignore: I would group lines into something like 

"Object.defineProperty(\n"
"  other, 'blocked_prop', { configurable: false}).blocked_prop")

because for me C's " really stand in the way, esp. for "'blocked_prop'"

But if you find your version more readable, that's perfectly ok

[Rico, 2011/02/18 07:49:09]

Done.

+          "other,"
+          "'blocked_prop',"
+          "{configurable: false}"
+      ").blocked_prop");

[antonm, 2011/02/17 15:44:12]

might be slightly easier for people not that experienced in defineProperty if
split into two parts:

Object.defineProperty(other, 'blocked_prop', ....);
other.blocked_prop

[Rico, 2011/02/18 07:49:09]

Done.

+  ExpectUndefined(
+      "Object.getOwnPropertyDescriptor(other, 'blocked_prop')");
+
+  // Regression test for issue 1171.
+  ExpectTrue("Object.isExtensible(other)");
+  CompileRun("Object.preventExtensions(other)");
+  ExpectTrue("Object.isExtensible(other)");
+
+  // Seal and freeze uses other functions which already includes access

[antonm, 2011/02/17 15:44:12]

function[s] hence include with not s, correct?

[Rico, 2011/02/18 07:49:09]

Changed comment 

+  // checks, but we check these anyway.

[antonm, 2011/02/17 15:44:12]

and maybe you can just drop this comment

[Rico, 2011/02/18 07:49:09]

Done.

+  CompileRun("Object.freeze(other)");
+  ExpectTrue("Object.isExtensible(other)");
+
+  CompileRun("Object.seal(other)");
+  ExpectTrue("Object.isExtensible(other)");
 }
 
 
 static bool GetOwnPropertyNamesNamedBlocker(Local<v8::Object> global,
                                             Local<Value> name,
                                             v8::AccessType type,
                                             Local<Value> data) {
   return false;
 }
 
@@ skipping 7075 matching lines @@
   v8::Handle<v8::Function> define_property =
       CompileRun("(function() {"
                  "  Object.defineProperty("
                  "    this,"
                  "    1,"
                  "    { configurable: true, enumerable: true, value: 3 });"
                  "})").As<Function>();
   context->DetachGlobal();
   define_property->Call(proxy, 0, NULL);
 }