GTTF: Use a fresh TestingBrowserProcess for each test, part #2

GTTF: Use a fresh TestingBrowserProcess for each test, part #2

For a detailed description see part #1, http://codereview.chromium.org/6478005/

BUG=61062
TEST=unit_tests, possibly more

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76034

[Paweł Hajdan Jr., 2011-02-17 21:24:25]

Sending just for some early comments, this still needs some work.

I've moved one of the tests to browser_tests to avoid issue described in
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...
and that seems to work. If that solution generally sounds good, I'm going to add
a comment in the gyp file and possibly rename the file to _browsertest (with svn
mv).

What do you think?

[Paweł Hajdan Jr., 2011-02-18 20:48:24]

ping (just asking for early comments, the CL needs more polish)

[Paweł Hajdan Jr., 2011-02-22 07:03:17]

+Jay, what do you think? This is just an early version.

[sky, 2011-02-22 18:55:01]

This seems fine to me. As you said, rename the file.

  -Scott

http://codereview.chromium.org/6532034/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/6532034/diff/1/chrome/chrome_tests.gypi#newcod...
chrome/chrome_tests.gypi:2270:
'browser/translate/translate_manager_unittest.cc',
remove extra newlines here.

[Jay Civelli, 2011-02-23 17:45:33]

Looks good.

[Paweł Hajdan Jr., 2011-02-23 19:56:11]

This should now be ready, please take a look.

I've renamed the file (_unittest -> _browsertest) and extracted include path
information to cld.gyp.

[sky, 2011-02-24 15:34:56]

LGTM

[Paweł Hajdan Jr., 2011-02-24 20:20:05]

The chrome/browser/renderer_host/test files have been moved to contents/ which
shouldn't depend on chrome/, so I have dropped the changes from that area.

I'm going to commit this tomorrow (the change is straightforward), but feel free
to take a look.