Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/policy/policy_map_unittest.cc

Issue 6532019: New policy protobuf protocol. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix memory leaks by introducing PolicyMap Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_map_unittest.cc
diff --git a/chrome/browser/policy/policy_map_unittest.cc b/chrome/browser/policy/policy_map_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e769b16897fad6917d78403776613876af4c461a
--- /dev/null
+++ b/chrome/browser/policy/policy_map_unittest.cc
@@ -0,0 +1,73 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/policy/policy_map.h"
+
+#include "base/scoped_ptr.h"
+#include "policy/configuration_policy_type.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+class PolicyMapTest : public testing::Test {
Mattias Nissler (ping if slow) 2011/02/17 09:27:20 If you don't need the fixture, you can just remove
Jakob Kummerow 2011/02/17 09:47:14 Done.
+ protected:
+ PolicyMapTest() {}
+};
+
+TEST_F(PolicyMapTest, SetAndGet) {
+ PolicyMap map;
+ map.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+ scoped_ptr<StringValue> expected(Value::CreateStringValue("aaa"));
Mattias Nissler (ping if slow) 2011/02/17 09:27:20 Why use scoped_ptrs? You can just declare a String
Jakob Kummerow 2011/02/17 09:47:14 Done.
+ EXPECT_TRUE(expected->Equals(map.Get(kPolicyHomepageLocation)));
+ map.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+ expected.reset(Value::CreateStringValue("bbb"));
+ EXPECT_TRUE(expected->Equals(map.Get(kPolicyHomepageLocation)));
+}
+
+TEST_F(PolicyMapTest, Equals) {
+ PolicyMap a;
+ a.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+ PolicyMap a2;
+ a2.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+ PolicyMap b;
+ b.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+ PolicyMap c;
+ c.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+ c.Set(kPolicyHomepageIsNewTabPage, Value::CreateBooleanValue(true));
+ EXPECT_FALSE(a.Equals(b));
+ EXPECT_FALSE(b.Equals(a));
+ EXPECT_FALSE(a.Equals(c));
+ EXPECT_FALSE(c.Equals(a));
+ EXPECT_TRUE(a.Equals(a2));
+ EXPECT_TRUE(a2.Equals(a));
+ PolicyMap empty1;
+ PolicyMap empty2;
+ EXPECT_TRUE(empty1.Equals(empty2));
+ EXPECT_TRUE(empty2.Equals(empty1));
+ EXPECT_FALSE(empty1.Equals(a));
+ EXPECT_FALSE(a.Equals(empty1));
+}
+
+TEST_F(PolicyMapTest, Swap) {
+ PolicyMap a;
+ a.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+ PolicyMap b;
+ b.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+ b.Set(kPolicyHomepageIsNewTabPage, Value::CreateBooleanValue(true));
+ a.Swap(&b);
+ scoped_ptr<Value> expected(Value::CreateStringValue("bbb"));
Mattias Nissler (ping if slow) 2011/02/17 09:27:20 same here.
Jakob Kummerow 2011/02/17 09:47:14 Done.
+ EXPECT_TRUE(expected->Equals(a.Get(kPolicyHomepageLocation)));
+ expected.reset(Value::CreateBooleanValue(true));
+ EXPECT_TRUE(expected->Equals(a.Get(kPolicyHomepageIsNewTabPage)));
+ expected.reset(Value::CreateStringValue("aaa"));
+ EXPECT_TRUE(expected->Equals(b.Get(kPolicyHomepageLocation)));
+
+ b.clear();
+ a.Swap(&b);
+ PolicyMap empty;
+ EXPECT_TRUE(a.Equals(empty));
+ EXPECT_FALSE(b.Equals(empty));
+}
+
+} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698