New policy protobuf protocol.

chrome/browser/policy/policy_map_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/policy/policy_map.h"
+
+#include "base/scoped_ptr.h"
+#include "policy/configuration_policy_type.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+class PolicyMapTest : public testing::Test {

[Mattias Nissler (ping if slow), 2011/02/17 09:27:20]

If you don't need the fixture, you can just remove it and replace TEST_F() with
TEST() below.

[Jakob Kummerow, 2011/02/17 09:47:14]

Done.

+ protected:
+  PolicyMapTest() {}
+};
+
+TEST_F(PolicyMapTest, SetAndGet) {
+  PolicyMap map;
+  map.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+  scoped_ptr<StringValue> expected(Value::CreateStringValue("aaa"));

[Mattias Nissler (ping if slow), 2011/02/17 09:27:20]

Why use scoped_ptrs? You can just declare a StringValue local.

[Jakob Kummerow, 2011/02/17 09:47:14]

Done.

+  EXPECT_TRUE(expected->Equals(map.Get(kPolicyHomepageLocation)));
+  map.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+  expected.reset(Value::CreateStringValue("bbb"));
+  EXPECT_TRUE(expected->Equals(map.Get(kPolicyHomepageLocation)));
+}
+
+TEST_F(PolicyMapTest, Equals) {
+  PolicyMap a;
+  a.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+  PolicyMap a2;
+  a2.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+  PolicyMap b;
+  b.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+  PolicyMap c;
+  c.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+  c.Set(kPolicyHomepageIsNewTabPage, Value::CreateBooleanValue(true));
+  EXPECT_FALSE(a.Equals(b));
+  EXPECT_FALSE(b.Equals(a));
+  EXPECT_FALSE(a.Equals(c));
+  EXPECT_FALSE(c.Equals(a));
+  EXPECT_TRUE(a.Equals(a2));
+  EXPECT_TRUE(a2.Equals(a));
+  PolicyMap empty1;
+  PolicyMap empty2;
+  EXPECT_TRUE(empty1.Equals(empty2));
+  EXPECT_TRUE(empty2.Equals(empty1));
+  EXPECT_FALSE(empty1.Equals(a));
+  EXPECT_FALSE(a.Equals(empty1));
+}
+
+TEST_F(PolicyMapTest, Swap) {
+  PolicyMap a;
+  a.Set(kPolicyHomepageLocation, Value::CreateStringValue("aaa"));
+  PolicyMap b;
+  b.Set(kPolicyHomepageLocation, Value::CreateStringValue("bbb"));
+  b.Set(kPolicyHomepageIsNewTabPage, Value::CreateBooleanValue(true));
+  a.Swap(&b);
+  scoped_ptr<Value> expected(Value::CreateStringValue("bbb"));

[Mattias Nissler (ping if slow), 2011/02/17 09:27:20]

same here.

[Jakob Kummerow, 2011/02/17 09:47:14]

Done.

+  EXPECT_TRUE(expected->Equals(a.Get(kPolicyHomepageLocation)));
+  expected.reset(Value::CreateBooleanValue(true));
+  EXPECT_TRUE(expected->Equals(a.Get(kPolicyHomepageIsNewTabPage)));
+  expected.reset(Value::CreateStringValue("aaa"));
+  EXPECT_TRUE(expected->Equals(b.Get(kPolicyHomepageLocation)));
+
+  b.clear();
+  a.Swap(&b);
+  PolicyMap empty;
+  EXPECT_TRUE(a.Equals(empty));
+  EXPECT_FALSE(b.Equals(empty));
+}
+
+}  // namespace policy