Issue 6527: Move code generation for storing to a reference out of the AST nodes, and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6527: Move code generation for storing to a reference out of the AST nodes, and... (Closed)

Created:
12 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move code generation for storing to a reference out of the AST nodes, and onto the platform-specific Reference class defined in codegen-*.cc. This removes all of the static code generator functions. Committed: http://code.google.com/p/v8/source/detail?r=460

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+377 lines, -516 lines)			Patch
M	src/ast.h	View		5 chunks	+0 lines, -35 lines	0 comments	Download
M	src/codegen-arm.cc	View		15 chunks	+190 lines, -246 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1	14 chunks	+187 lines, -235 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-07 11:02:10 UTC) #2

LGTM - it's kinda difficult to review with all this moving code around, but it
looks good.

http://codereview.chromium.org/6527/diff/203/6
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/6527/diff/203/6#newcode216
Line 216: Operand SlotOperand(Slot* slot, Register tmp);
I guess there's a good reason why this isn't const and the other operand helpers
are?

Expand Messages | Collapse Messages