Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: src/ast.h

Issue 6527: Move code generation for storing to a reference out of the AST nodes, and... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/codegen-arm.cc » ('j') | src/codegen-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
===================================================================
--- src/ast.h (revision 448)
+++ src/ast.h (working copy)
@@ -140,9 +140,6 @@
};
-class Reference;
-enum InitState { CONST_INIT, NOT_CONST_INIT };
-
class Expression: public Node {
public:
virtual Expression* AsExpression() { return this; }
@@ -153,17 +150,6 @@
// statement. This is used to transform postfix increments to
// (faster) prefix increments.
virtual void MarkAsStatement() { /* do nothing */ }
-
- // Generate code to store into an expression evaluated as the left-hand
- // side of an assignment. The code will expect the stored value on top of
- // the expression stack, and a reference containing the expression
- // immediately below that. This function is overridden for expression
- // types that can be stored into.
- virtual void GenerateStoreCode(CodeGenerator* cgen,
- Reference* ref,
- InitState init_state) {
- UNREACHABLE();
- }
};
@@ -758,13 +744,6 @@
// Bind this proxy to the variable var.
void BindTo(Variable* var);
- // Generate code to store into an expression evaluated as the left-hand
- // side of an assignment. The code will expect the stored value on top of
- // the expression stack, and a reference containing the expression
- // immediately below that.
- virtual void GenerateStoreCode(CodeGenerator* cgen,
- Reference* ref,
- InitState init_state);
protected:
Handle<String> name_;
Variable* var_; // resolved variable, or NULL
@@ -840,13 +819,6 @@
Type type() const { return type_; }
int index() const { return index_; }
- // Generate code to store into an expression evaluated as the left-hand
- // side of an assignment. The code will expect the stored value on top of
- // the expression stack, and a reference containing the expression
- // immediately below that.
- virtual void GenerateStoreCode(CodeGenerator* cgen,
- Reference* ref,
- InitState init_state);
private:
Variable* var_;
Type type_;
@@ -874,13 +846,6 @@
// during preparsing.
static Property* this_property() { return &this_property_; }
- // Generate code to store into an expression evaluated as the left-hand
- // side of an assignment. The code will expect the stored value on top of
- // the expression stack, and a reference containing the expression
- // immediately below that.
- virtual void GenerateStoreCode(CodeGenerator* cgen,
- Reference* ref,
- InitState init_state);
private:
Expression* obj_;
Expression* key_;
« no previous file with comments | « no previous file | src/codegen-arm.cc » ('j') | src/codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698