Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 6525005: Revert r74860 as it broke arm: (Closed)

Created:
9 years, 10 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

Revert r74860 as it broke arm: DOM UI options handler cleanup: - improve StripColon - remove superfluous parens (clang would catch these if they weren't inside ifdefs) - move a couple more files to the abbreviated string definition style - use SetBoolean rather than SetString("true") BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -131 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/about_page_handler.cc View 2 chunks +39 lines, -26 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.cc View 1 chunk +41 lines, -23 lines 0 comments Download
M chrome/browser/dom_ui/options/content_settings_handler.cc View 1 chunk +113 lines, -60 lines 0 comments Download
M chrome/browser/dom_ui/options/dom_options_util.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/options/language_options_handler_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698