Chromium Code Reviews Chromium Code Reviews
Issue 6518013:
Update Chromoting login UI (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: remoting/client/extension/chromoting_tab.html |
| diff --git a/remoting/client/extension/chromoting_tab.html b/remoting/client/extension/chromoting_tab.html |
| index a0c1cc1343030f6acb06d884e35cf46f388515b2..b0e58dd0dd4932c923944c1155633b6f14bbeb4e 100644 |
| --- a/remoting/client/extension/chromoting_tab.html |
| +++ b/remoting/client/extension/chromoting_tab.html |
| @@ -14,11 +14,39 @@ found in the LICENSE file. |
| <body class="chromoting_body" onload="init();"> |
| <div id="status_msg" class="status_msg"></div> |
| <div id="login_panel" class="login_panel"> |
|
Sergey Ulanov
2011/02/14 21:52:49
Alpha added login_panel for local login. It looks
garykac
2011/02/14 22:11:53
The changes to Alpha's pre-local login are from Al
|
| - <table> |
| - <tr><td>Username:</td><td><input type="text" id="username" value="demo"/></td></tr> |
| - <tr><td>Password:</td><td><input type="password" id="password" value="none" /></td></tr> |
| - <tr><td colspan="2"><input type="button" value="Login" onclick="submitLogin();" /></td></tr> |
| - </table> |
| + <table cellspacing="3" cellpadding="5" border="0"><tr><td valign="top" |
|
Sergey Ulanov
2011/02/14 21:52:49
use CSS instead of border/cellpadding/cellspacing
garykac
2011/02/14 22:11:53
This formatting was all duplicated verbatim from G
|
| + style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa"> |
| + <table align="center" border="0" cellpadding="1" cellspacing="0"> |
|
Sergey Ulanov
2011/02/14 21:52:49
table inside of table, why?
garykac
2011/02/14 22:11:53
Gmail.
|
| + <tr> |
| + <td align="center" colspan="2"> |
| + <font size="-1">Sign in with your</font> |
|
Sergey Ulanov
2011/02/14 21:52:49
don't use <font>. Also I don't think we should ins
garykac
2011/02/14 22:11:53
Again, this is from Gmail.
|
| + <table><tr> |
|
Sergey Ulanov
2011/02/14 21:52:49
Why do you need <table> here. just set position:fl
garykac
2011/02/14 22:11:53
layout copied from GMail.
|
| + <td valign="top"><img src="https://www.google.com/accounts/google_transparent.gif" |
| + alt="Google"></img></td> |
| + <td valign="middle"><font size="+0"><b>Account</b></font></td> |
| + </tr></table> |
| + </td> |
| + </tr><tr> |
| + <td align="right" nowrap="nowrap"> |
| + <span class="gaia le lbl">Username:</span> |
| + </td><td> |
| + <input type="text" id="username" value="" class="gaia le val"/> |
| + </td> |
| + </tr><tr> |
| + <td align="right" nowrap="nowrap"> |
| + <span class="gaia le lbl">Password:</span> |
| + </td> |
| + <td> |
| + <input type="password" id="password" value="" |
| + class="gaia le val"/> |
| + </td> |
| + </tr><tr> |
| + <td></td> |
| + <td><input type="button" value="Sign in" class="gaia le button" |
| + onclick="submitLogin();"/></td> |
| + </tr> |
| + </table> |
| + </tr></td></table> |
| </div> |
| <div id="plugin_scroll_panel" class="plugin-scroll-panel"> |
| <embed name="chromoting" id="chromoting" |
