remoting/client/extension/chromoting_tab.html - Issue 6518013: Update Chromoting login UI

Side by Side Diff: remoting/client/extension/chromoting_tab.html

Issue 6518013: Update Chromoting login UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!--	1 <!--

2 Copyright (c) 2010 The Chromium Authors. All rights reserved.	2 Copyright (c) 2010 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <html>	7 <html>

8 <head>	8 <head>

9 <title id="title">Chromoting Session</title>	9 <title id="title">Chromoting Session</title>

10 <link rel="stylesheet" type="text/css" href="main.css" />	10 <link rel="stylesheet" type="text/css" href="main.css" />

11 <script type="text/javascript" src="base.js"></script>	11 <script type="text/javascript" src="base.js"></script>

12 <script type="text/javascript" src="chromoting_tab.js"></script>	12 <script type="text/javascript" src="chromoting_tab.js"></script>

13 </head>	13 </head>

14 <body class="chromoting_body" onload="init();">	14 <body class="chromoting_body" onload="init();">

15 <div id="status_msg" class="status_msg"></div>	15 <div id="status_msg" class="status_msg"></div>

16 <div id="login_panel" class="login_panel">	16 <div id="login_panel" class="login_panel">
	Sergey Ulanov 2011/02/14 21:52:49 Alpha added login_panel for local login. It looks Alpha added login_panel for local login. It looks like your change is for Gaia login. Maybe we need another panel for that. garykac 2011/02/14 22:11:53 The changes to Alpha's pre-local login are from Al Show quoted text On 2011/02/14 21:52:49, sergeyu wrote: > Alpha added login_panel for local login. It looks like your change is for Gaia > login. Maybe we need another panel for that. The changes to Alpha's pre-local login are from Alberto, and (as I understand it) are Gaia login. The local login screen is separate. Both the chromoting dir login and the pre-local login use the same css styles now.
17 <table>	17 <table cellspacing="3" cellpadding="5" border="0"><tr><td valign="top"
	Sergey Ulanov 2011/02/14 21:52:49 use CSS instead of border/cellpadding/cellspacing use CSS instead of border/cellpadding/cellspacing/bgcolor attributes. define style in CSS instead of inline garykac 2011/02/14 22:11:53 This formatting was all duplicated verbatim from G Show quoted text On 2011/02/14 21:52:49, sergeyu wrote: > use CSS instead of border/cellpadding/cellspacing/bgcolor attributes. define > style in CSS instead of inline This formatting was all duplicated verbatim from GMail.
18 <tr><td>Username:</td><td><input type="text" id="username" value="demo"/ ></td></tr>	18 style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa">

19 <tr><td>Password:</td><td><input type="password" id="password" value="no ne" /></td></tr>	19 <table align="center" border="0" cellpadding="1" cellspacing="0">
	Sergey Ulanov 2011/02/14 21:52:49 table inside of table, why? table inside of table, why? garykac 2011/02/14 22:11:53 Gmail. Show quoted text On 2011/02/14 21:52:49, sergeyu wrote: > table inside of table, why? Gmail.
20 <tr><td colspan="2"><input type="button" value="Login" onclick="submitLo gin();" /></td></tr>	20 <tr>

21 </table>	21 <td align="center" colspan="2">

	22 <font size="-1">Sign in with your</font>
	Sergey Ulanov 2011/02/14 21:52:49 don't use <font>. Also I don't think we should ins don't use <font>. Also I don't think we should insert image inside of text, especially using tables - it is not very localizible and accessible garykac 2011/02/14 22:11:53 Again, this is from Gmail. Show quoted text On 2011/02/14 21:52:49, sergeyu wrote: > don't use <font>. Also I don't think we should insert image inside of text, > especially using tables - it is not very localizible and accessible Again, this is from Gmail.
	23 <table><tr>
	Sergey Ulanov 2011/02/14 21:52:49 Why do you need <table> here. just set position:fl Why do you need <table> here. just set position:float for the image. garykac 2011/02/14 22:11:53 layout copied from GMail. Show quoted text On 2011/02/14 21:52:49, sergeyu wrote: > Why do you need <table> here. just set position:float for the image. layout copied from GMail.
	24 <td valign="top"><img src="https://www.google.com/accounts/googl e_transparent.gif"

	25 alt="Google"></img></td>

	26 <td valign="middle"><font size="+0"><b>Account</b></font></td>

	27 </tr></table>

	28 </td>

	29 </tr><tr>

	30 <td align="right" nowrap="nowrap">

	31 <span class="gaia le lbl">Username:</span>

	32 </td><td>

	33 <input type="text" id="username" value="" class="gaia le val"/>

	34 </td>

	35 </tr><tr>

	36 <td align="right" nowrap="nowrap">

	37 <span class="gaia le lbl">Password:</span>

	38 </td>

	39 <td>

	40 <input type="password" id="password" value=""

	41 class="gaia le val"/>

	42 </td>

	43 </tr><tr>

	44 <td></td>

	45 <td><input type="button" value="Sign in" class="gaia le button"

	46 onclick="submitLogin();"/></td>

	47 </tr>

	48 </table>

	49 </tr></td></table>

22 </div>	50 </div>

23 <div id="plugin_scroll_panel" class="plugin-scroll-panel">	51 <div id="plugin_scroll_panel" class="plugin-scroll-panel">

24 <embed name="chromoting" id="chromoting"	52 <embed name="chromoting" id="chromoting"

25 src="about://none" type="pepper-application/x-chromoting">	53 src="about://none" type="pepper-application/x-chromoting">

26 </div>	54 </div>

27 </body>	55 </body>

28 </html>	56 </html>

OLD	NEW

« no previous file with comments | « no previous file | remoting/client/extension/client.js » ('j') | no next file with comments »