crash-reporter: Use standard logging and new libchromeos Process code

crash-reporter: Use standard logging and new libchromeos Process code

Change-Id: Ie085d61d4d79c0df38e51debaa044d701a860c89

BUG=none
TEST=unit tests / UserCrash / CrashSender

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ef853af

[petkov, 2011-02-25 19:28:34]

LGTM but submit the ebuild dependency first if needed.

http://codereview.chromium.org/6517001/diff/8001/Makefile
File Makefile (right):

http://codereview.chromium.org/6517001/diff/8001/Makefile#newcode22
Makefile:22: COMMON_LIBS = -lbase -lchromeos -lpthread -lglib-2.0 -lgflags -lrt
$(LDCONFIG)
Do you need to add a dependency to libchromeos to the crash-reporter ebuild
first?

[kmixter1, 2011-03-02 12:04:20]

PTAL - look at the change for 5->6.  It's neat.

[petkov, 2011-03-02 17:53:20]

http://codereview.chromium.org/6517001/diff/14001/crash_reporter.cc
File crash_reporter.cc (right):

http://codereview.chromium.org/6517001/diff/14001/crash_reporter.cc#newcode192
crash_reporter.cc:192: close(new_fd);
how does this work? don't you need to close inside the loop? otherwise, you'd
open /dev/null 4 times and exit from the loop even if stderr/stdout are not
open...

and then -- really, how does this work? isn't there a race between you opening
/dev/null and ... then kernel opening stdout? maybe clarify in the comments.

[kmixter1, 2011-03-02 19:08:58]

http://codereview.chromium.org/6517001/diff/14001/crash_reporter.cc
File crash_reporter.cc (right):

http://codereview.chromium.org/6517001/diff/14001/crash_reporter.cc#newcode192
crash_reporter.cc:192: close(new_fd);
On 2011/03/02 17:53:20, petkov wrote:
> how does this work? don't you need to close inside the loop? otherwise, you'd
> open /dev/null 4 times and exit from the loop even if stderr/stdout are not
> open...
> 
> and then -- really, how does this work? isn't there a race between you opening
> /dev/null and ... then kernel opening stdout? maybe clarify in the comments.

Does the comment make sense now?

[petkov, 2011-03-02 19:16:05]

LGTM