Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: crash_collector.h

Issue 6517001: crash-reporter: Use standard logging and new libchromeos Process code (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master
Patch Set: More comments Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile ('k') | crash_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_collector.h
diff --git a/crash_collector.h b/crash_collector.h
index f3fcbe596f7461db0f29f05597ec9decd0ce923c..3c09e2fdfe435ab1886e2cf990dc1fef8fc79a2b 100644
--- a/crash_collector.h
+++ b/crash_collector.h
@@ -13,8 +13,6 @@
#include "base/file_path.h"
#include "gtest/gtest_prod.h" // for FRIEND_TEST
-class SystemLogging;
-
// User crash collector.
class CrashCollector {
public:
@@ -26,11 +24,9 @@ class CrashCollector {
virtual ~CrashCollector();
// Initialize the crash collector for detection of crashes, given a
- // crash counting function, metrics collection enabled oracle, and
- // system logger facility.
+ // crash counting function, and metrics collection enabled oracle.
void Initialize(CountCrashFunction count_crash,
- IsFeedbackAllowedFunction is_metrics_allowed,
- SystemLogging *logger);
+ IsFeedbackAllowedFunction is_metrics_allowed);
protected:
friend class CrashCollectorTest;
@@ -66,9 +62,6 @@ class CrashCollector {
// Otherwise returns the number of bytes written.
int WriteNewFile(const FilePath &filename, const char *data, int size);
- int ForkExecAndPipe(std::vector<const char *> &arguments,
- const char *output_file);
-
// Return a filename that has only [a-z0-1_] characters by mapping
// all others into '_'.
std::string Sanitize(const std::string &name);
@@ -140,7 +133,6 @@ class CrashCollector {
CountCrashFunction count_crash_function_;
IsFeedbackAllowedFunction is_feedback_allowed_function_;
- SystemLogging *logger_;
std::string extra_metadata_;
const char *forced_crash_directory_;
const char *lsb_release_;
« no previous file with comments | « Makefile ('k') | crash_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698