Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/arm/full-codegen-arm.cc

Issue 6515005: Strict mode delete. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index 2685fcb735cee0501a1d20c5c5231dc75375fdd6..932ccfaf382aebe1427ebb9f026adaae2f211ca7 100644
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -3063,13 +3063,17 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {
} else {
VisitForStackValue(prop->obj());
VisitForStackValue(prop->key());
+ __ mov(r1, Operand(Smi::FromInt(strict_mode_flag())));
+ __ push(r1);
Martin Maly 2011/02/14 05:15:22 Is there a preferred register to use instead?
Mads Ager (chromium) 2011/02/14 10:27:24 r1 is fine, r0 would be fine too. No preferences h
__ InvokeBuiltin(Builtins::DELETE, CALL_JS);
context()->Plug(r0);
}
} else if (var->is_global()) {
- __ ldr(r1, GlobalObjectOperand());
- __ mov(r0, Operand(var->name()));
- __ Push(r1, r0);
+ ASSERT(strict_mode_flag() == kNonStrictMode);
Mads Ager (chromium) 2011/02/14 10:27:24 Maybe duplicate the comment here to explain the as
Martin Maly 2011/02/14 21:46:51 Done.
+ __ ldr(r2, GlobalObjectOperand());
+ __ mov(r1, Operand(var->name()));
+ __ mov(r0, Operand(Smi::FromInt(kNonStrictMode)));
+ __ Push(r2, r1, r0);
__ InvokeBuiltin(Builtins::DELETE, CALL_JS);
context()->Plug(r0);
} else {

Powered by Google App Engine
This is Rietveld 408576698