Strict mode delete.

src/arm/full-codegen-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3045 matching lines @@
         // The subexpression does not have side effects.
         context()->Plug(false);
       } else if (prop != NULL) {
         if (prop->is_synthetic()) {
           // Result of deleting parameters is false, even when they rewrite
           // to accesses on the arguments object.
           context()->Plug(false);
         } else {
           VisitForStackValue(prop->obj());
           VisitForStackValue(prop->key());
+          __ mov(r1, Operand(Smi::FromInt(strict_mode_flag())));
+          __ push(r1);

[Martin Maly, 2011/02/14 05:15:22]

Is there a preferred register to use instead?

[Mads Ager (chromium), 2011/02/14 10:27:24]

r1 is fine, r0 would be fine too. No preferences here. The only reason why the
register choice would matter here is if you need to push more than one value at
which point you can use Push to use the stm (store multiple) instruction. Here
it is clearer to just visit for stack value for the two first parameters and
just push the last one as you are doing.

           __ InvokeBuiltin(Builtins::DELETE, CALL_JS);
           context()->Plug(r0);
         }
       } else if (var->is_global()) {
-        __ ldr(r1, GlobalObjectOperand());
-        __ mov(r0, Operand(var->name()));
-        __ Push(r1, r0);
+        ASSERT(strict_mode_flag() == kNonStrictMode);

[Mads Ager (chromium), 2011/02/14 10:27:24]

Maybe duplicate the comment here to explain the assert?

[Martin Maly, 2011/02/14 21:46:51]

Done.

+        __ ldr(r2, GlobalObjectOperand());
+        __ mov(r1, Operand(var->name()));
+        __ mov(r0, Operand(Smi::FromInt(kNonStrictMode)));
+        __ Push(r2, r1, r0);
         __ InvokeBuiltin(Builtins::DELETE, CALL_JS);
         context()->Plug(r0);
       } else {
         // Non-global variable.  Call the runtime to try to delete from the
         // context where the variable was introduced.
         __ push(context_register());
         __ mov(r2, Operand(var->name()));
         __ push(r2);
         __ CallRuntime(Runtime::kDeleteContextSlot, 2);
         context()->Plug(r0);
@@ skipping 612 matching lines @@
   __ mov(r1, Operand(r1, ASR, 1));  // Un-smi-tag value.
   __ add(pc, r1, Operand(masm_->CodeObject()));
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM