Issue 6510007: Printing: Delete dead code in PrintJob and cleanup corresponding code in Prin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6510007: Printing: Delete dead code in PrintJob and cleanup corresponding code in Prin... (Closed)

Created:
9 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Printing: Delete dead code in PrintJob and cleanup corresponding code in PrintingContext. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74844

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -56 lines)			Patch
M	chrome/browser/printing/print_job.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_job.cc	View	7 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/printing/print_job_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_worker.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_job_worker.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/printer_query.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/printer_query.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	printing/printing_context.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	printing/printing_context_cairo.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/printing_context_cairo.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	printing/printing_context_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/printing_context_mac.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	printing/printing_context_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/printing_context_win.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

This is a very late follow up to http://codereview.chromium.org/21057. In print_job.cc, is_print_dialog_box_shown_ is never true ...

9 years, 10 months ago (2011-02-12 00:25:19 UTC) #1

lgtm!