Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: chrome/browser/printing/print_job.cc

Issue 6510007: Printing: Delete dead code in PrintJob and cleanup corresponding code in Prin... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job.cc
===================================================================
--- chrome/browser/printing/print_job.cc (revision 74700)
+++ chrome/browser/printing/print_job.cc (working copy)
@@ -22,7 +22,6 @@
worker_(),
settings_(),
is_job_pending_(false),
- is_print_dialog_box_shown_(false),
is_canceling_(false) {
DCHECK(ui_message_loop_);
// This is normally a UI message loop, but in unit tests, the message loop is
@@ -36,7 +35,6 @@
ui_message_loop_->RemoveDestructionObserver(this);
// The job should be finished (or at least canceled) when it is destroyed.
DCHECK(!is_job_pending_);
- DCHECK(!is_print_dialog_box_shown_);
DCHECK(!is_canceling_);
if (worker_.get())
DCHECK(worker_->message_loop() == NULL);
@@ -49,7 +47,6 @@
DCHECK(!source_);
DCHECK(!worker_.get());
DCHECK(!is_job_pending_);
- DCHECK(!is_print_dialog_box_shown_);
DCHECK(!is_canceling_);
DCHECK(!document_.get());
source_ = source;
@@ -114,7 +111,6 @@
DCHECK_EQ(ui_message_loop_, MessageLoop::current());
DCHECK(worker_->message_loop());
DCHECK(!is_job_pending_);
- DCHECK(!is_print_dialog_box_shown_);
if (!worker_->message_loop() || is_job_pending_)
return;
@@ -141,13 +137,6 @@
MessageLoop* worker_loop = worker_->message_loop();
if (worker_loop) {
- if (is_print_dialog_box_shown_) {
- // Make sure there is no Print... dialog box.
- worker_loop->PostTask(FROM_HERE, NewRunnableMethod(
- worker_.get(), &PrintJobWorker::DismissDialog));
- is_print_dialog_box_shown_ = false;
- }
-
ControlledWorkerShutdown();
is_job_pending_ = false;
@@ -216,10 +205,6 @@
return is_job_pending_;
}
-bool PrintJob::is_print_dialog_box_shown() const {
- return is_print_dialog_box_shown_;
-}
-
PrintedDocument* PrintJob::document() const {
return document_.get();
}
@@ -246,8 +231,6 @@
switch (event_details.type()) {
case JobEventDetails::FAILED: {
settings_.Clear();
- // Update internal state.
- is_print_dialog_box_shown_ = false;
// No need to cancel since the worker already canceled itself.
Stop();
break;
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698