Issue 6508011: Add tarball option and print out what gsutil would do to make it easier to debug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6508011: Add tarball option and print out what gsutil would do to make it easier to debug. (Closed)

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
dgarrett, scottz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Add tarball option and print out what gsutil would do to make it easier to debug. Change-Id: I041053a017ee0aabbbeb30b4753bf9594e8d1d83 BUG=chromium-os:8364 TEST=Ran it manually here. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c04833c

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : flip bit #

Total comments: 2

Patch Set 4 : One more time #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	archive_build.sh	View	1 2 3	7 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgarrett

LGTM http://codereview.chromium.org/6508011/diff/3/archive_build.sh File archive_build.sh (right): http://codereview.chromium.org/6508011/diff/3/archive_build.sh#newcode254 archive_build.sh:254: if [ -n "$FLAGS_gsutil_archive" -a ${FLAGS_debug} -eq ${FLAGS_FALSE} ...

9 years, 10 months ago (2011-02-12 01:46:05 UTC) #3

scottz

9 years, 10 months ago (2011-02-12 01:49:01 UTC) #4

http://codereview.chromium.org/6508011/diff/3/archive_build.sh
File archive_build.sh (right):

http://codereview.chromium.org/6508011/diff/3/archive_build.sh#newcode254
archive_build.sh:254: if [ -n "$FLAGS_gsutil_archive" -a ${FLAGS_debug} -eq
${FLAGS_FALSE} ]; then
On that note since we are only either doing what is in the if or saying what we
are doing I would suggest checking if ${FLAGS_debug} is set then print out what
would be run and exit the function.

Otherwise execute the rest of the function.

Expand Messages | Collapse Messages