Add tarball option and print out what gsutil would do to make it easier to debug.

archive_build.sh

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to archive build results.  Used by the buildbots.
 
 # --- BEGIN COMMON.SH BOILERPLATE ---
 # Load common CrOS utilities.  Inside the chroot this file is installed in
@@ skipping 27 matching lines @@
 
 # Flags
 DEFINE_boolean archive_debug $FLAGS_TRUE \
     "Archive debug information for build"
 DEFINE_string board "$DEFAULT_BOARD" \
     "The board to build packages for."
 DEFINE_string build_number "" \
     "The build-bot build number (when called by buildbot only)." "b"
 DEFINE_string chroot "$DEFAULT_CHROOT_DIR" \
     "The chroot of the build to archive."
+DEFINE_boolean debug $FLAGS_FALSE "Run, but don't upload anything."
 DEFINE_boolean factory_install_mod $FLAGS_FALSE \
     "Modify image for factory install purposes"
 DEFINE_boolean factory_test_mod $FLAGS_FALSE \
     "Modify image for factory testing purposes"
 DEFINE_string from "$DEFAULT_FROM" \
     "Directory to archive"
 DEFINE_string gsutil "gsutil" \
     "Location of gsutil"
 DEFINE_string gsd_gen_index "" \
     "Location of gsd_generate_index.py"
 DEFINE_string acl "private" \
     "ACL to set on GSD archives"
 DEFINE_string gsutil_archive "" \
     "Optional datastore archive location"
 DEFINE_integer keep_max 0 "Maximum builds to keep in archive (0=all)"
 DEFINE_boolean official_build $FLAGS_FALSE \
     "Set CHROMEOS_OFFICIAL=1 for release builds."
+DEFINE_string test_tarball "" "Optional path to test tarball to archive"
 DEFINE_boolean test_mod $FLAGS_TRUE "Modify image for testing purposes"
 DEFINE_boolean prebuilt_upload $FLAGS_FALSE "Upload prebuilt binary packages."
 DEFINE_string to "$DEFAULT_TO" "Directory of build archive"
 DEFINE_string zipname "image.zip" "Name of zip file to create."
 
 # Parse command line
 FLAGS "$@" || exit 1
 eval set -- "${FLAGS_ARGV}"
 
 # Set if default from path is used
@@ skipping 166 matching lines @@
 
 # Make sure files are readable
 chmod 644 "$ZIPFILE" "${FLAGS_to}/LATEST"
 chmod 755 "$OUTDIR"
 cp -f  "${FLAGS_from}/au-generator.zip" "${OUTDIR}/"
 
 
 function gsutil_archive() {
   IN_PATH="$1"
   OUT_PATH="$2"
-  if [ -n "$FLAGS_gsutil_archive" ]
-  then
+  echo "Using gsutil to archive to ${OUT_PATH}..."
+  if [ -n "$FLAGS_gsutil_archive" -a ${FLAGS_debug} -eq ${FLAGS_FALSE} ]; then

[dgarrett, 2011/02/12 01:46:05]

I'm being picky just to prove a really read this....

I tend to prefer that expressions like this return true if you are going to run
the if block instead of false.

if [ "$FLAGS_gsutil_archive" -a -n ${FLAGS_debug} -eq ${FLAGS_TRUE} ]; then

[scottz, 2011/02/12 01:49:01]

On that note since we are only either doing what is in the if or saying what we
are doing I would suggest checking if ${FLAGS_debug} is set then print out what
would be run and exit the function.

Otherwise execute the rest of the function. 

     FULL_OUT_PATH="${FLAGS_gsutil_archive}/${OUT_PATH}"
-    echo "Using gsutil to archive to ${OUT_PATH}..."
     ${FLAGS_gsutil} cp ${IN_PATH} ${FULL_OUT_PATH}
     ${FLAGS_gsutil} setacl ${FLAGS_acl} ${FULL_OUT_PATH}
     if [ -n "$FLAGS_gsd_gen_index" ]
     then
       echo "Updating indexes..."
       ${FLAGS_gsd_gen_index} \
         --gsutil=${FLAGS_gsutil} \
         -a ${FLAGS_acl} \
         -p ${FULL_OUT_PATH} ${FLAGS_gsutil_archive}
     fi
+  else
+    echo -n "In debug mode.  Would have run: "
+    echo "gsutil cp ${IN_PATH} <gsutil_archive>/${OUT_PATH}"
   fi
 }
 
 if [ $FLAGS_test_mod -eq $FLAGS_TRUE -a $FLAGS_official_build -eq $FLAGS_TRUE ]
 then
   echo "Creating hwqual archive"
   HWQUAL_NAME="chromeos-hwqual-${FLAGS_board}-${CHROMEOS_VERSION_STRING}"
   "${SCRIPTS_DIR}/archive_hwqual" --from "${OUTDIR}" \
     --output_tag "${HWQUAL_NAME}"
   gsutil_archive "${OUTDIR}/${HWQUAL_NAME}.tar.bz2" \
     "${LAST_CHANGE}/${HWQUAL_NAME}.tar.bz2"
 fi
 
 
 if [ $FLAGS_prebuilt_upload -eq $FLAGS_TRUE ]; then
   # Construct prebuilt upload command.
   # This will upload prebuilt packages to Google Storage.
   prebuilt_cmd="${GCLIENT_ROOT}/chromite/buildbot/prebuilt.py"
   prebuilt_cmd="$prebuilt_cmd -u gs://chromeos-prebuilt --git-sync -V master"
   prebuilt_cmd="$prebuilt_cmd -p ${GCLIENT_ROOT} -b ${FLAGS_board}"
 
   if [ "${FLAGS_board}" == "x86-generic" ]
   then
     prebuilt_cmd="$prebuilt_cmd --sync-host"
   fi
 
-  echo "Running $prebuilt_cmd"
-  $prebuilt_cmd
+  if [ ${FLAGS_debug} -eq ${FLAGS_FALSE} ]; then
+    echo "Running $prebuilt_cmd"
+    $prebuilt_cmd
+  else
+    echo "Would have run $prebuilt_cmd"
+  fi
 fi
 
 gsutil_archive "${ZIPFILE}" "${LAST_CHANGE}/${FLAGS_zipname}"
 
 if [ $FLAGS_archive_debug -eq $FLAGS_TRUE ]; then
   echo "Generating Breakpad symbols"
   ! ${SCRIPTS_DIR}/cros_generate_breakpad_symbols --board=${FLAGS_board}
   echo "Creating debug archive"
   pushd "${FLAGS_chroot}/build/${FLAGS_board}/usr/lib"
   sudo tar czf "${OUTDIR}/debug.tgz" --checkpoint=1000 --exclude\
       debug/usr/local/autotest --exclude debug/tests debug
   CMD="chown \${SUDO_UID}:\${SUDO_GID} ${OUTDIR}/debug.tgz"
   sudo sh -c "${CMD}"
   popd
   gsutil_archive "${OUTDIR}/debug.tgz" "${LAST_CHANGE}/debug.tgz"
 fi
 
 if [ $FLAGS_factory_test_mod -eq $FLAGS_TRUE ] || \
    [ $FLAGS_factory_install_mod -eq $FLAGS_TRUE ]; then
   gsutil_archive "${FACTORY_ZIPFILE}" \
     "${LAST_CHANGE}/factory_${FLAGS_zipname}"
 fi
+
 gsutil_archive "${FLAGS_to}/LATEST" "LATEST"
 
+if [ -n "${FLAGS_test_tarball}" ]; then
+  gsutil_archive "${FLAGS_test_tarball}" "${LAST_CHANGE}/test_results.tgz"
+fi
+
 # Purge old builds if necessary
 if [ $FLAGS_keep_max -gt 0 ]; then
   echo "Deleting old builds (all but the newest ${FLAGS_keep_max})..."
   cd "$FLAGS_to"
   # +2 because line numbers start at 1 and need to skip LATEST file
   rm -rf `ls -t1 | tail --lines=+$(($FLAGS_keep_max + 2))`
   cd -
 fi
 
 echo "Done."