Issue 6505002: Pepper GLES fixes to support 3D in NaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6505002: Pepper GLES fixes to support 3D in NaCl. (Closed)

Created:
9 years, 10 months ago by neb

Modified:
9 years, 7 months ago

Reviewers:
David Springer, piman

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pepper GLES fixes to support 3D in NaCl. BUG=none TEST=NaCl:910 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74674

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	ppapi/c/dev/ppb_opengles_dev.h	View		2 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

David Springer

9 years, 10 months ago (2011-02-11 22:27:40 UTC) #3

http://codereview.chromium.org/6505002/diff/1/ppapi/c/dev/ppb_opengles_dev.h
File ppapi/c/dev/ppb_opengles_dev.h (right):

http://codereview.chromium.org/6505002/diff/1/ppapi/c/dev/ppb_opengles_dev.h#...
ppapi/c/dev/ppb_opengles_dev.h:14: #ifndef __gl2_h_
Can someone please explain why we are shadowing "standard" types here?  This is
very dangerous and will lead to all kinds of difficult bugs, and especially will
make it hard to properly test things like SDK installations.  I recommend
pulling this #ifndef block out and using #include <GLES2/gl2.h>

Expand Messages | Collapse Messages