Mac: Move prefs around in preparation for the content settings window.

Mac: Move prefs around in preparation for the content settings window.

Also introduce scaffolding for the actual content settings dialog.

xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button

+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around

+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
  new method.

+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n

+ bubble xibs:
* Enable "Manage" links now that they open a window

Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj

BUG=34656, 34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39588

[Nico, 2010-02-22 00:26:38]

The list of touched files is pretty huge, but it's mostly 2-line changes. And
lots of xib files.

[Nico, 2010-02-22 00:31:57]

Added a link to 4 screenshots to the description.

[viettrungluu, 2010-02-22 00:57:39]

LGTM with nits.

http://codereview.chromium.org/650124/diff/36/46
File chrome/browser/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/650124/diff/36/46#newcode14
chrome/browser/cocoa/browser_window_cocoa.mm:14: #include
"chrome/browser/cocoa/browser_window_cocoa.h"
#include first

http://codereview.chromium.org/650124/diff/36/46#newcode321
chrome/browser/cocoa/browser_window_cocoa.mm:321: ContentSettingsType
settingsType,
Being a C++ method, C++ naming rules apply. So |settings_type|.

http://codereview.chromium.org/650124/diff/36/48
File chrome/browser/cocoa/clear_browsing_data_controller.mm (right):

http://codereview.chromium.org/650124/diff/36/48#newcode165
chrome/browser/cocoa/clear_browsing_data_controller.mm:165: Browser* browser =
Browser::Create(profile_);
Is this code common between platforms? Ought it not go somewhere common?

http://codereview.chromium.org/650124/diff/36/50
File chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm (right):

http://codereview.chromium.org/650124/diff/36/50#newcode7
chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm:7: #import
"chrome/browser/cocoa/content_blocked_bubble_controller.h"
Shouldn't this go before even the #import <Cocoa/Cocoa.h>? I've completely
ignored the ordering for unit tests, mind you.

http://codereview.chromium.org/650124/diff/36/52
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/650124/diff/36/52#newcode7
chrome/browser/cocoa/content_settings_dialog_controller.mm:7: #import
"chrome/browser/cocoa/content_settings_dialog_controller.h"
First, I say! First!

http://codereview.chromium.org/650124/diff/36/52#newcode16
chrome/browser/cocoa/content_settings_dialog_controller.mm:16: static
ContentSettingsDialogController* g_instance = nil;
We're mostly now putting stuff in anonymous namespaces. That way, when you add
stuff, you won't have to change it.

http://codereview.chromium.org/650124/diff/36/52#newcode40
chrome/browser/cocoa/content_settings_dialog_controller.mm:40:
g_instance->lastSelectedTab_.GetValue());
You should validate that settingsType contains a valid value.

http://codereview.chromium.org/650124/diff/36/52#newcode52
chrome/browser/cocoa/content_settings_dialog_controller.mm:52: NSString* nibpath
= [mac_util::MainAppBundle()
I'd prefer it if you just broke the line after the '='.

http://codereview.chromium.org/650124/diff/36/52#newcode72
chrome/browser/cocoa/content_settings_dialog_controller.mm:72: // The controller
will clean itself up.
You should be a little clearer in what this means.

http://codereview.chromium.org/650124/diff/36/55
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/650124/diff/36/55#newcode8
chrome/browser/cocoa/preferences_window_controller.mm:8: #include
"app/l10n_util.h"
There should really be a blank line before this one.

[Nico, 2010-02-22 01:47:51]

Thanks.

I addressed all comments, but codereview currently times out for me,
so I can't add all these neat "Done." notes :-/

Submitting.

On Sun, Feb 21, 2010 at 4:57 PM,  <viettrungluu@chromium.org> wrote:
> LGTM with nits.
>
>
> http://codereview.chromium.org/650124/diff/36/46
> File chrome/browser/cocoa/browser_window_cocoa.mm (right):
>
> http://codereview.chromium.org/650124/diff/36/46#newcode14
> chrome/browser/cocoa/browser_window_cocoa.mm:14: #include
> "chrome/browser/cocoa/browser_window_cocoa.h"
> #include first
>
> http://codereview.chromium.org/650124/diff/36/46#newcode321
> chrome/browser/cocoa/browser_window_cocoa.mm:321: ContentSettingsType
> settingsType,
> Being a C++ method, C++ naming rules apply. So |settings_type|.
>
> http://codereview.chromium.org/650124/diff/36/48
> File chrome/browser/cocoa/clear_browsing_data_controller.mm (right):
>
> http://codereview.chromium.org/650124/diff/36/48#newcode165
> chrome/browser/cocoa/clear_browsing_data_controller.mm:165: Browser*
> browser = Browser::Create(profile_);
> Is this code common between platforms? Ought it not go somewhere common?
>
> http://codereview.chromium.org/650124/diff/36/50
> File chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
> (right):
>
> http://codereview.chromium.org/650124/diff/36/50#newcode7
> chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm:7:
> #import "chrome/browser/cocoa/content_blocked_bubble_controller.h"
> Shouldn't this go before even the #import <Cocoa/Cocoa.h>? I've
> completely ignored the ordering for unit tests, mind you.
>
> http://codereview.chromium.org/650124/diff/36/52
> File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):
>
> http://codereview.chromium.org/650124/diff/36/52#newcode7
> chrome/browser/cocoa/content_settings_dialog_controller.mm:7: #import
> "chrome/browser/cocoa/content_settings_dialog_controller.h"
> First, I say! First!
>
> http://codereview.chromium.org/650124/diff/36/52#newcode16
> chrome/browser/cocoa/content_settings_dialog_controller.mm:16: static
> ContentSettingsDialogController* g_instance = nil;
> We're mostly now putting stuff in anonymous namespaces. That way, when
> you add stuff, you won't have to change it.
>
> http://codereview.chromium.org/650124/diff/36/52#newcode40
> chrome/browser/cocoa/content_settings_dialog_controller.mm:40:
> g_instance->lastSelectedTab_.GetValue());
> You should validate that settingsType contains a valid value.
>
> http://codereview.chromium.org/650124/diff/36/52#newcode52
> chrome/browser/cocoa/content_settings_dialog_controller.mm:52: NSString*
> nibpath = [mac_util::MainAppBundle()
> I'd prefer it if you just broke the line after the '='.
>
> http://codereview.chromium.org/650124/diff/36/52#newcode72
> chrome/browser/cocoa/content_settings_dialog_controller.mm:72: // The
> controller will clean itself up.
> You should be a little clearer in what this means.
>
> http://codereview.chromium.org/650124/diff/36/55
> File chrome/browser/cocoa/preferences_window_controller.mm (right):
>
> http://codereview.chromium.org/650124/diff/36/55#newcode8
> chrome/browser/cocoa/preferences_window_controller.mm:8: #include
> "app/l10n_util.h"
> There should really be a blank line before this one.
>
> http://codereview.chromium.org/650124
>