HSTS: add net-internals UI.

net/base/dns_util.cc

Index: net/base/dns_util.cc
diff --git a/net/base/dns_util.cc b/net/base/dns_util.cc
index f1e0de442babefc5a0e61c9506fc1df78929637c..f4306ab84eb06aaf27d4646266330f6db45c2b52 100644
--- a/net/base/dns_util.cc
+++ b/net/base/dns_util.cc
@@ -56,6 +56,17 @@ bool DNSDomainFromDot(const std::string& dotted, std::string* out) {
   return true;
 }
 
+std::string DNSDomainToString(const std::string& domain) {
+  std::string ret;
+
+  for (unsigned i = 0; domain[i]; i += domain[i] + 1) {

[eroman, 2011/02/16 20:12:45]

I am concerned about bounds checking in this function.

Invalid inputs could cause us to index array out of bounds on domain...

The substr() inside the loop might be OK since I think it validates bounds. But
you should likely add a |i < domain.size()| to the condition.

Also, I think there is some sign confusion.

I believe domain[i] is going to be of type |char|, which is signed. So if the
length was 255 you would actually end up subtracting 1 no? I reckon you should
static_cast to an "unsigned char"

[agl, 2011/02/16 22:46:22]

This function assumes that the input is in DNS format. This means that the
lengths are < 64, they you don't go off the end etc.

However, I've added the checks anyway.

+    if (i)
+      ret += ".";
+    ret += domain.substr(i + 1, domain[i]);
+  }
+  return ret;
+}
+
 bool IsSTD3ASCIIValidCharacter(char c) {
   if (c <= 0x2c)
     return false;