HSTS: add net-internals UI.

net/base/dns_util.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/dns_util.h"
 
 #include <cstring>
 
 namespace net {
 
@@ skipping 38 matching lines @@
   }
 
   if (namelen + 1 > sizeof name)
     return false;
   name[namelen++] = 0;  // This is the root label (of length 0).
 
   *out = std::string(name, namelen);
   return true;
 }
 
+std::string DNSDomainToString(const std::string& domain) {
+  std::string ret;
+
+  for (unsigned i = 0; domain[i]; i += domain[i] + 1) {

[eroman, 2011/02/16 20:12:45]

I am concerned about bounds checking in this function.

Invalid inputs could cause us to index array out of bounds on domain...

The substr() inside the loop might be OK since I think it validates bounds. But
you should likely add a |i < domain.size()| to the condition.

Also, I think there is some sign confusion.

I believe domain[i] is going to be of type |char|, which is signed. So if the
length was 255 you would actually end up subtracting 1 no? I reckon you should
static_cast to an "unsigned char"

[agl, 2011/02/16 22:46:22]

This function assumes that the input is in DNS format. This means that the
lengths are < 64, they you don't go off the end etc.

However, I've added the checks anyway.

+    if (i)
+      ret += ".";
+    ret += domain.substr(i + 1, domain[i]);
+  }
+  return ret;
+}
+
 bool IsSTD3ASCIIValidCharacter(char c) {
   if (c <= 0x2c)
     return false;
   if (c >= 0x7b)
     return false;
   if (c >= 0x2e && c <= 0x2f)
     return false;
   if (c >= 0x3a && c <= 0x40)
     return false;
   if (c >= 0x5b && c <= 0x60)
     return false;
   return true;
 }
 
 std::string TrimEndingDot(const std::string& host) {
   std::string host_trimmed = host;
   size_t len = host_trimmed.length();
   if (len > 1 && host_trimmed[len - 1] == '.')
     host_trimmed.erase(len - 1);
   return host_trimmed;
 }
 
 }  // namespace net