Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 6493004: Implement basic crash detection and shutdown handling for out of process PPAP... (Closed)

Created:
9 years, 10 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Implement basic crash detection and shutdown handling for out of process PPAPI plugins. Currently when a crash is detected we just delete as much stuff as is convenient, clear the plugin's backing store, and continue running. It does not hook up a sad plugin page yet. This adds a "proxy" interface for the proxy to tell the PPAPI backend implementation in the renderer about proxy-related stuff (like the plugin crashing). This also implements keeping the process alive for a period of time so we can re-use the same process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74965

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -81 lines) Patch
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_channel.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
A chrome/ppapi_plugin/plugin_process_dispatcher.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/plugin_process_dispatcher.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A ppapi/c/private/ppb_proxy_private.h View 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 5 chunks +5 lines, -14 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 4 chunks +17 lines, -0 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 4 chunks +16 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_proxy_impl.h View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.h View 2 chunks +9 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 2 chunks +62 lines, -52 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
http://codereview.chromium.org/6493004/diff/1/webkit/plugins/ppapi/resource_tracker.cc File webkit/plugins/ppapi/resource_tracker.cc (right): http://codereview.chromium.org/6493004/diff/1/webkit/plugins/ppapi/resource_tracker.cc#newcode164 webkit/plugins/ppapi/resource_tracker.cc:164: DLOG_IF(ERROR, !CheckIdType(instance, PP_ID_TYPE_INSTANCE)) This code just moved from above ...
9 years, 10 months ago (2011-02-14 23:00:05 UTC) #1
jam
9 years, 10 months ago (2011-02-14 23:08:29 UTC) #2
lgtm

http://codereview.chromium.org/6493004/diff/1/chrome/ppapi_plugin/plugin_proc...
File chrome/ppapi_plugin/plugin_process_dispatcher.cc (right):

http://codereview.chromium.org/6493004/diff/1/chrome/ppapi_plugin/plugin_proc...
chrome/ppapi_plugin/plugin_process_dispatcher.cc:19: const int
kPluginReleaseTimeMS = 30 * 1000;  // 30 seconds.
nit: most of the code uses Ms

Powered by Google App Engine
This is Rietveld 408576698