Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/plugin/plugin_channel.cc

Issue 6493004: Implement basic crash detection and shutdown handling for out of process PPAP... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/ppapi_plugin/plugin_process_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/plugin_channel.cc
===================================================================
--- chrome/plugin/plugin_channel.cc (revision 74733)
+++ chrome/plugin/plugin_channel.cc (working copy)
@@ -23,6 +23,8 @@
#include "ipc/ipc_channel_posix.h"
#endif
+namespace {
+
class PluginReleaseTask : public Task {
public:
void Run() {
@@ -31,8 +33,9 @@
};
// How long we wait before releasing the plugin process.
-static const int kPluginReleaseTimeMS = 5 * 60 * 1000; // 5 minutes
+const int kPluginReleaseTimeMs = 5 * 60 * 1000; // 5 minutes
+} // namespace
// If a sync call to the renderer results in a modal dialog, we need to have a
// way to know so that we can run a nested message loop to simulate what would
@@ -133,7 +136,6 @@
IPC::Channel* channel_;
};
-
PluginChannel* PluginChannel::GetPluginChannel(int renderer_id,
MessageLoop* ipc_message_loop) {
// Map renderer ID to a (single) channel to that process.
@@ -176,7 +178,7 @@
base::CloseProcessHandle(renderer_handle_);
MessageLoop::current()->PostDelayedTask(FROM_HERE, new PluginReleaseTask(),
- kPluginReleaseTimeMS);
+ kPluginReleaseTimeMs);
}
bool PluginChannel::Send(IPC::Message* msg) {
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/ppapi_plugin/plugin_process_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698