chrome/browser/autofill/phone_field_unittest.cc - Issue 6480083: Changed parsing code for the phonenumbers fields to incorporate different com...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/phone_field_unittest.cc

Issue 6480083: Changed parsing code for the phonenumbers fields to incorporate different com... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/phone_field.cc ('K') | « chrome/browser/autofill/phone_field.cc ('k') | chrome/test/data/autofill/heuristics/input/form_phones_en.html » ('j') | chrome/test/data/autofill/heuristics/input/form_phones_en.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/phone_field_unittest.cc

===================================================================

--- chrome/browser/autofill/phone_field_unittest.cc (revision 74701)

+++ chrome/browser/autofill/phone_field_unittest.cc (working copy)

@@ -171,6 +171,9 @@

}

TEST_F(PhoneFieldTest, ThreePartPhoneNumber) {

+ // Phone in format field-field-field could be either area code-prefix-

dhollowa 2011/02/16 00:25:37 I had a bit of trouble parsing this comment. I mi

GeorgeY 2011/02/16 20:53:34 Done.

+ // suffix, or country code-area code-phone. The only distinguishing feature is

+ // size: prefix is no bigger than 3 characters, suffix - 4.

list_.push_back(

new AutoFillField(webkit_glue::FormField(ASCIIToUTF16("Phone:"),

ASCIIToUTF16("dayphone1"),

@@ -184,7 +187,7 @@

ASCIIToUTF16("dayphone2"),

string16(),

ASCIIToUTF16("text"),

- 0,

+ 3,

false),

ASCIIToUTF16("prefix1")));

list_.push_back(

@@ -192,7 +195,7 @@

ASCIIToUTF16("dayphone3"),

string16(),

ASCIIToUTF16("text"),

- 0,

+ 4,

false),

ASCIIToUTF16("suffix1")));

list_.push_back(