Changed parsing code for the phonenumbers fields to incorporate different com...

chrome/browser/autofill/phone_field_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/scoped_ptr.h"
 #include "base/scoped_vector.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/phone_field.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/glue/form_field.h"
@@ skipping 153 matching lines @@
   ASSERT_TRUE(field_->GetFieldInfo(&field_type_map_));
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("areacode1")) != field_type_map_.end());
   EXPECT_EQ(PHONE_HOME_CITY_CODE, field_type_map_[ASCIIToUTF16("areacode1")]);
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("phone1")) != field_type_map_.end());
   EXPECT_EQ(PHONE_HOME_NUMBER, field_type_map_[ASCIIToUTF16("phone1")]);
 }
 
 TEST_F(PhoneFieldTest, ThreePartPhoneNumber) {
+  // Phone in format field-field-field could be either area code-prefix-

[dhollowa, 2011/02/16 00:25:37]

I had a bit of trouble parsing this comment.  I might suggest rewording as:

Phone in format <field> - <field> - <field> could be either <area code> -
<prefix> - <suffix>, or <country code> - <area code> - <phone>. The only
distinguishing feature is size: <prefix> is no bigger than 3 characters, and
<suffix> is no bigger than 4.

[GeorgeY, 2011/02/16 20:53:34]

Done.

+  // suffix, or country code-area code-phone. The only distinguishing feature is
+  // size: prefix is no bigger than 3 characters, suffix - 4.
   list_.push_back(
       new AutoFillField(webkit_glue::FormField(ASCIIToUTF16("Phone:"),
                                                ASCIIToUTF16("dayphone1"),
                                                string16(),
                                                ASCIIToUTF16("text"),
                                                0,
                                                false),
                         ASCIIToUTF16("areacode1")));
   list_.push_back(
       new AutoFillField(webkit_glue::FormField(ASCIIToUTF16("-"),
                                                ASCIIToUTF16("dayphone2"),
                                                string16(),
                                                ASCIIToUTF16("text"),
-                                               0,
+                                               3,
                                                false),
                         ASCIIToUTF16("prefix1")));
   list_.push_back(
       new AutoFillField(webkit_glue::FormField(ASCIIToUTF16("-"),
                                                ASCIIToUTF16("dayphone3"),
                                                string16(),
                                                ASCIIToUTF16("text"),
-                                               0,
+                                               4,
                                                false),
                         ASCIIToUTF16("suffix1")));
   list_.push_back(
       new AutoFillField(webkit_glue::FormField(ASCIIToUTF16("ext.:"),
                                                ASCIIToUTF16("dayphone4"),
                                                string16(),
                                                ASCIIToUTF16("text"),
                                                0,
                                                false),
                         ASCIIToUTF16("ext1")));
@@ skipping 142 matching lines @@
   EXPECT_EQ(PHONE_FAX_CITY_CODE, field_type_map_[ASCIIToUTF16("areacode1")]);
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("prefix1")) != field_type_map_.end());
   EXPECT_EQ(PHONE_FAX_NUMBER, field_type_map_[ASCIIToUTF16("prefix1")]);
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("suffix1")) != field_type_map_.end());
   EXPECT_EQ(PHONE_FAX_NUMBER, field_type_map_[ASCIIToUTF16("suffix1")]);
 }
 
 }  // namespace