Chromium Code Reviews Chromium Code Reviews
Issue 6480083:
Changed parsing code for the phonenumbers fields to incorporate different com... (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/| Index: chrome/browser/autofill/autofill_resources.grd |
| =================================================================== |
| --- chrome/browser/autofill/autofill_resources.grd (revision 74701) |
| +++ chrome/browser/autofill/autofill_resources.grd (working copy) |
| @@ -108,17 +108,29 @@ |
| <message name="IDS_AUTOFILL_PHONE_RE"> |
| phone<!-- de-DE -->|telefonnummer<!-- es -->|telefono|teléfono<!-- fr-FR -->|telfixe<!-- ja-JP -->|電話<!-- pt-BR, pt-PT -->|telefone|telemovel<!-- ru -->|телефон<!-- zh-CN -->|电话 |
| </message> |
| + <message name="IDS_AUTOFILL_COUNTRY_CODE_RE"> |
| + country.*code|ccode |
| + </message> |
| + <message name="IDS_AUTOFILL_AREA_CODE_NOTEXT_RE"> |
| + ^\($ |
| + </message> |
| <message name="IDS_AUTOFILL_AREA_CODE_RE"> |
| - area code |
| + area.*code|acode |
| </message> |
| <message name="IDS_AUTOFILL_FAX_RE"> |
| fax<!-- fr-FR -->|télécopie|telecopie<!-- ja-JP -->|ファックス<!-- ru -->|факс<!-- zh-CN -->|传真<!-- zh-TW -->|傳真 |
| </message> |
| + <message name="IDS_AUTOFILL_PHONE_PREFIX_SEPARATOR_RE"> |
| + ^-$|\)$ |
|
Ilya Sherman
2011/02/16 09:33:22
nit: You have "^" only on the left, but "$" both o
dhollowa
2011/02/16 21:19:19
Yes, this was a mistake in the old regex as well.
GeorgeY
2011/02/17 00:21:18
Done.
|
| + </message> |
| + <message name="IDS_AUTOFILL_PHONE_SUFFIX_SEPARATOR_RE"> |
| + ^-$ |
| + </message> |
| <message name="IDS_AUTOFILL_PHONE_PREFIX_RE"> |
| - ^-$|\)$|prefix<!-- fr-FR -->|preselection<!-- pt-BR, pt-PT -->|ddd |
| + prefix<!-- fr-FR -->|preselection<!-- pt-BR, pt-PT -->|ddd |
| </message> |
| <message name="IDS_AUTOFILL_PHONE_SUFFIX_RE"> |
| - ^-$|suffix |
| + suffix |
| </message> |
| <message name="IDS_AUTOFILL_PHONE_EXTENSION_RE"> |
| ext<!-- pt-BR, pt-PT -->|ramal |
