GTTF: Use a fresh TestingBrowserProcess for each test, part #1

GTTF: Use a fresh TestingBrowserProcess for each test, part #1

This is going to be done in multiple steps,
because lots of tests depend on global TestingBrowserProcess.

However, the current solution is very error-prone,
and may lead to state being carried from one test
to another (via NotificationService), resulting in crashes.

In theory the ScopedTestingBrowserProcess could be made
empty for now, but re-initializing g_browser_process inside it
has two benefits:

1) It verifies that changing g_browser_process actually works.

2) It protects at least a subset of tests from carrying state.

BUG=61062
TEST=unit_tests, possibly more

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74926

[sky, 2011-02-09 22:06:32]

This is pretty invasive. Isn't there a way to inject g_browser_process before
each test is run?

[Paweł Hajdan Jr., 2011-02-14 10:16:24]

PTAL

After the chat, I've added a base class where it was possible. In one case
(AutocompleteTest I think) I couldn't use a typedef because of a friend class
declaration. The typedef then would make the compile fail.

[sky, 2011-02-14 17:01:19]

How come you didn't use the superclass more often?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/appcache/chro...
File chrome/browser/appcache/chrome_appcache_service_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/appcache/chro...
chrome/browser/appcache/chrome_appcache_service_unittest.cc:19: class
ChromeAppCacheServiceTest : public testing::Test {
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/history_contents_provider_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
chrome/browser/autocomplete/history_contents_provider_unittest.cc:34: class
HistoryContentsProviderTest : public testing::Test,
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/history_quick_provider_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
chrome/browser/autocomplete/history_quick_provider_unittest.cc:68: class
HistoryQuickProviderTest : public testing::Test,
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
chrome/browser/autocomplete/history_url_provider_unittest.cc:94: class
HistoryURLProviderTest : public testing::Test,
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/keyword_provider_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
chrome/browser/autocomplete/keyword_provider_unittest.cc:15: class
KeywordProviderTest : public testing::Test {
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/search_provider_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete/...
chrome/browser/autocomplete/search_provider_unittest.cc:32: class
SearchProviderTest : public testing::Test,
TestingBrowserProcessTest?

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete_...
File chrome/browser/autocomplete_history_manager_unittest.cc (right):

http://codereview.chromium.org/6478005/diff/6005/chrome/browser/autocomplete_...
chrome/browser/autocomplete_history_manager_unittest.cc:28: class
AutocompleteHistoryManagerTest : public testing::Test {
TestingBrowserProcessTest?

[Paweł Hajdan Jr., 2011-02-14 20:56:28]

PTAL

[sky, 2011-02-14 21:49:42]

LGTM