Stackable file_util for FileAPIs. Sample code for discussion. Incomplete. Cannot be compiled.

Stackable file_util for FileAPIs. Sample code for discussion. Incomplete. Cannot be compiled.

BUG=
TEST=

[Dai Mikurube (google.com), 2011-02-10 08:35:12]

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_file...
File webkit/fileapi/file_system_file_util_base.cc (right):

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_file...
webkit/fileapi/file_system_file_util_base.cc:64: return
file_util::CopyFile(from_path, to_path);
Just calling file_util::CopyFile() without fs_context.

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_file...
File webkit/fileapi/file_system_file_util_base.h (right):

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_file...
webkit/fileapi/file_system_file_util_base.h:71: // ...
FYI: Actually, not all functions in file_util are required here.

1) Need to implement functions required by one of extended file_util stacks
here.
2) No need to override all functions here in child extended file_util stacks,
for example, QuotaFileUtil.

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_oper...
File webkit/fileapi/file_system_operation_context.h (right):

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/file_system_oper...
webkit/fileapi/file_system_operation_context.h:14: int64 GetAllowedGrowth();
Some information for obfuscation can be added in this class.

[ericu, 2011-02-10 20:41:54]

It looks to me like both QuotaFileUtil and ObfuscatedFileUtil are making raw
FileUtil calls.  How do I get an ObfuscatedQuotaFileUtil?  I'm going to want
quota+obfuscation for the sandbox, but mount points will want no obfuscation
[and may or may not need quota].

In other words, I see how either obfuscation or quota can be layered on top of
FileUtil, but I don't see how to layer them on top of each other.

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/quota_file_util.cc
File webkit/fileapi/quota_file_util.cc (right):

http://codereview.chromium.org/6471019/diff/1/webkit/fileapi/quota_file_util....
webkit/fileapi/quota_file_util.cc:27: return file_util::CopyFile(from_path,
to_path);
Would this also call into the quota system somehow to report the increase in
used storage?

[Dai Mikurube (google.com), 2011-02-14 08:48:11]

There were no GetInstance() for ObfuscatedFileUtil and QuotaFileUtil. I've added
it to them in the Patch Set 2. The layering order is hard coded in GetInstance()
for now.

(It's still not able to be compiled!)

In addition, changed signatures of virtual functions. The signatures correspond
to FileUtilProxy functions.

[kinuko, 2011-02-15 13:03:03]

Our current rough plan is as following:
(Hoping that the figure gives you some idea, but we'll explain it tomorrow)
----------------------------------------------------------------

Current:

  FileSystemOperation (or FileSystemDirUrlRequestJob)
    |
    v
  FileUtilProxy::X
    (proxies to the FILE thread)
    |
    v
  file_util::X' [@FILE]

----------------------------------------------------------------

Stage 1:

  FileSystemOperation (or FileSystemDirUrlRequestJob)
    |
    v
  FileSystemFileUtilProxy (currently this is missing from the patch)
    * proxies to the FILE thread
    * takes FileSystemContext as an argument
    * create FileSystemOperationContext (a portable object passed to the FILE
thread task)
    |
    v
  FileSystemFileUtilBase::X [@FILE]
    |
    v
  file_util::X' [@FILE]

----------------------------------------------------------------

Stage X:

  FileSystemOperation (or FileSystemDirUrlRequestJob)
    |
    v
  FileSystemFileUtilProxy
    * proxies to the FILE thread
    * takes FileSystemContext as an argument
    * create FileSystemOperationContext (a portable object passed to the FILE
thread task)
    |
    v
  ObfuscationFileUtil::X [@FILE]
  QuotaFileUtil::X [@FILE]
  FileSystemFileUtilBase::X [@FILE]
    * ObfuscationFileUtil and QuotaFileUtil inherit from FileSystemFileUtilBase,
so that
       for some methods the base methods are directly called
    |
    v
  file_util::X' [@FILE]


On 2011/02/14 08:48:11, Dai Mikurube wrote:
> There were no GetInstance() for ObfuscatedFileUtil and QuotaFileUtil. I've
added
> it to them in the Patch Set 2. The layering order is hard coded in
GetInstance()
> for now.
> 
> (It's still not able to be compiled!)
> 
> In addition, changed signatures of virtual functions. The signatures
correspond
> to FileUtilProxy functions.

[Dai Mikurube (google.com), 2011-02-15 14:13:57]

Updated. Patch Set 3. (webkit/fileapi/file_system_file_util_proxy.cc is still
cannot be compiled.)

[ericu, 2011-02-15 23:58:14]

I still have the previous questions.

Also, it looks like now you're changing all the existing call sites of
file_util methods, which shouldn't be necessary.  Take a look at the
latest version of my CL for how I've segregated things:
http://codereview.chromium.org/6286038.

On Tue, Feb 15, 2011 at 6:13 AM,  <dmikurube@google.com> wrote:
> Updated. Patch Set 3. (webkit/fileapi/file_system_file_util_proxy.cc is
> still
> cannot be compiled.)
>
> http://codereview.chromium.org/6471019/
>

[Dai Mikurube (google.com), 2011-03-03 21:27:17]

Working on http://codereview.chromium.org/6604020/ . Closing this CL.