src/api.cc - Issue 647015: Remove the LookupResult IsValid method because it is confusing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

===================================================================

--- src/api.cc (revision 3900)

+++ src/api.cc (working copy)

@@ -2207,7 +2207,7 @@

i::Handle<i::String> key_obj = Utils::OpenHandle(*key);

i::LookupResult lookup;

self_obj->LookupRealNamedPropertyInPrototypes(*key_obj, &lookup);

- if (lookup.IsValid()) {

+ if (lookup.IsProperty()) {

PropertyAttributes attributes;

i::Handle<i::Object> result(self_obj->GetProperty(*self_obj,

&lookup,

@@ -2226,7 +2226,7 @@