src/arm/stub-cache-arm.cc - Issue 647015: Remove the LookupResult IsValid method because it is confusing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/stub-cache-arm.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/stub-cache-arm.cc

===================================================================

--- src/arm/stub-cache-arm.cc (revision 3900)

+++ src/arm/stub-cache-arm.cc (working copy)

@@ -579,7 +579,7 @@

stub_compiler->CheckPrototypes(object, receiver, holder,

scratch1, scratch2, name, miss);

- if (lookup->IsValid() && lookup->IsCacheable()) {

+ if (lookup->IsProperty() && lookup->IsCacheable()) {

compiler->CompileCacheable(masm,

stub_compiler,

receiver,

@@ -985,7 +985,7 @@

// If we call a constant function when the interceptor returns

// the no-result sentinel, generate code that optimizes this case.

- if (lookup.IsValid() &&

+ if (lookup.IsProperty() &&

lookup.IsCacheable() &&

lookup.type() == CONSTANT_FUNCTION &&

lookup.GetConstantFunction()->is_compiled() &&

« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »