chrome_frame/urlmon_bind_status_callback.cc - Issue 6469103: If we switch into ChromeFrame as a result of a redirect then we need to navig...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/urlmon_bind_status_callback.cc

Issue 6469103: If we switch into ChromeFrame as a result of a redirect then we need to navig... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/urlmon_bind_status_callback.cc

===================================================================

--- chrome_frame/urlmon_bind_status_callback.cc (revision 75628)

+++ chrome_frame/urlmon_bind_status_callback.cc (working copy)

@@ -249,15 +249,10 @@

HRESULT hr = S_OK;

- // Remember the last redirected URL in case we get switched into

- // chrome frame

- if (status_code == BINDSTATUS_REDIRECTING) {

- ScopedComPtr<BindContextInfo> info;

- BindContextInfo::FromBindContext(bind_ctx_, info.Receive());

- DCHECK(info);

- if (info)

- info->set_url(status_text);

- }

+ // TODO(ananta)

+ // ChromeFrame will not be informed of any redirects which occur while we

+ // switch into Chrome. This will only break the moniker patch which is

+ // legacy and needs to be deleted.

if (ShouldCacheProgress(status_code)) {

saved_progress_.push_back(new Progress(progress, progress_max, status_code,

« no previous file with comments | « chrome_frame/protocol_sink_wrap.h ('k') | chrome_frame/urlmon_url_request.cc » ('j') | no next file with comments »