AutocompletePopupContentsView must override View::PaintChildren to prevent views

chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h

Index: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h
diff --git a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h
index 12088c7486430f2a1d3cb7a2486a300c5db56879..1f11150786bfb65b8d60d916e979e8f9c0824609 100644
--- a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h
+++ b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h
@@ -69,7 +69,9 @@ class AutocompletePopupContentsView : public views::View,
 
   // Overridden from views::View:
   virtual void OnPaint(gfx::Canvas* canvas);
-  virtual void PaintChildren(gfx::CanvasSkia* canvas);
+  virtual void PaintChildren(gfx::Canvas* canvas) {

[Peter Kasting, 2011/02/21 04:59:30]

Nit: Never define virtual functions in the class declaration.  Write an
out-of-line definition.

[varunjain, 2011/02/21 16:36:30]

Done.

+    // We paint our children inside OnPaint().

[Peter Kasting, 2011/02/21 04:59:30]

Nit: Add more detail: "... It's important not to allow anyone else to trigger
child-painting by calling this directly, since things like making the background
slightly transparent only happen inside OnPaint().

[varunjain, 2011/02/21 16:36:30]

Done.

+  }
   virtual void Layout();
   virtual void LayoutChildren();
   virtual void OnMouseEntered(const views::MouseEvent& event);
@@ -81,6 +83,8 @@ class AutocompletePopupContentsView : public views::View,
   virtual views::View* GetViewForPoint(const gfx::Point& point);
 
  protected:
+  virtual void PaintResultViews(gfx::CanvasSkia* canvas);
+
   // Calculates the height needed to show all the results in the model.
   virtual int CalculatePopupHeight();
   virtual AutocompleteResultView* CreateResultView(