AutocompletePopupContentsView must override View::PaintChildren to prevent views

chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_AUTOCOMPLETE_AUTOCOMPLETE_POPUP_CONTENTS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_AUTOCOMPLETE_AUTOCOMPLETE_POPUP_CONTENTS_VIEW_H_
 #pragma once
 
 #include "chrome/browser/autocomplete/autocomplete.h"
 #include "chrome/browser/autocomplete/autocomplete_popup_model.h"
@@ skipping 51 matching lines @@
   // Overridden from AutocompleteResultViewModel:
   virtual bool IsSelectedIndex(size_t index) const;
   virtual bool IsHoveredIndex(size_t index) const;
   virtual const SkBitmap* GetSpecialIcon(size_t index) const;
 
   // Overridden from ui::AnimationDelegate:
   virtual void AnimationProgressed(const ui::Animation* animation);
 
   // Overridden from views::View:
   virtual void OnPaint(gfx::Canvas* canvas);
-  virtual void PaintChildren(gfx::CanvasSkia* canvas);
+  virtual void PaintChildren(gfx::Canvas* canvas) {

[Peter Kasting, 2011/02/21 04:59:30]

Nit: Never define virtual functions in the class declaration.  Write an
out-of-line definition.

[varunjain, 2011/02/21 16:36:30]

Done.

+    // We paint our children inside OnPaint().

[Peter Kasting, 2011/02/21 04:59:30]

Nit: Add more detail: "... It's important not to allow anyone else to trigger
child-painting by calling this directly, since things like making the background
slightly transparent only happen inside OnPaint().

[varunjain, 2011/02/21 16:36:30]

Done.

+  }
   virtual void Layout();
   virtual void LayoutChildren();
   virtual void OnMouseEntered(const views::MouseEvent& event);
   virtual void OnMouseMoved(const views::MouseEvent& event);
   virtual void OnMouseExited(const views::MouseEvent& event);
   virtual bool OnMousePressed(const views::MouseEvent& event);
   virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);
   virtual bool OnMouseDragged(const views::MouseEvent& event);
   virtual views::View* GetViewForPoint(const gfx::Point& point);
 
  protected:
+  virtual void PaintResultViews(gfx::CanvasSkia* canvas);
+
   // Calculates the height needed to show all the results in the model.
   virtual int CalculatePopupHeight();
   virtual AutocompleteResultView* CreateResultView(
       AutocompleteResultViewModel* model,
       int model_index,
       const gfx::Font& font,
       const gfx::Font& bold_font);
 
   scoped_ptr<AutocompletePopupModel> model_;
 
@@ skipping 73 matching lines @@
   // The popup sizes vertically using an animation when the popup is getting
   // shorter (not larger, that makes it look "slow").
   ui::SlideAnimation size_animation_;
   gfx::Rect start_bounds_;
   gfx::Rect target_bounds_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompletePopupContentsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_AUTOCOMPLETE_AUTOCOMPLETE_POPUP_CONTENTS_VIEW_H_