Issue 6469074: AutocompletePopupContentsView must override View::PaintChildren to prevent views

Issue 6469074: AutocompletePopupContentsView must override View::PaintChildren to prevent views (Closed)

Created:
9 years, 10 months ago by varunjain

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

AutocompletePopupContentsView must override View::PaintChildren to prevent views from "accidentally" painting. This bug was introduced in Cl http://codereview.chromium.org/6349101 BUG=73473 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75562

Patch Set 2 : modified according to ocmments #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -22 lines)			Patch
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/touch_autocomplete_popup_contents_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/autocomplete/touch_autocomplete_popup_contents_view.cc	View		2 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/6469074/diff/1/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h (right): http://codereview.chromium.org/6469074/diff/1/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h#newcode72 chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h:72: virtual void PaintChildren(gfx::Canvas* canvas) { Nit: Never define ...

9 years, 10 months ago (2011-02-21 04:59:30 UTC) #2

varunjain

9 years, 10 months ago (2011-02-21 16:36:30 UTC) #3

http://codereview.chromium.org/6469074/diff/1/chrome/browser/ui/views/autocom...
File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h
(right):

http://codereview.chromium.org/6469074/diff/1/chrome/browser/ui/views/autocom...
chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h:72:
virtual void PaintChildren(gfx::Canvas* canvas) {
On 2011/02/21 04:59:30, Peter Kasting wrote:
> Nit: Never define virtual functions in the class declaration.  Write an
> out-of-line definition.

Done.

http://codereview.chromium.org/6469074/diff/1/chrome/browser/ui/views/autocom...
chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h:73: //
We paint our children inside OnPaint().
On 2011/02/21 04:59:30, Peter Kasting wrote:
> Nit: Add more detail: "... It's important not to allow anyone else to trigger
> child-painting by calling this directly, since things like making the
background
> slightly transparent only happen inside OnPaint().

Done.

Expand Messages | Collapse Messages