base/synchronization/waitable_event_win.cc - Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_win.cc

Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Updating to follow EXPECTED, ACTUAL pattern on DCHECK_EQ() Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/synchronization/waitable_event_win.cc

diff --git a/base/synchronization/waitable_event_win.cc b/base/synchronization/waitable_event_win.cc

index 0fcf488eb1e9b918cd11d0315c68b5317db6233b..a0e39c1571a205421b84e59270d867e86b19258c 100644

--- a/base/synchronization/waitable_event_win.cc

+++ b/base/synchronization/waitable_event_win.cc

@@ -50,7 +50,7 @@ bool WaitableEvent::Wait() {

DWORD result = WaitForSingleObject(handle_, INFINITE);

// It is most unexpected that this should ever fail. Help consumers learn

// about it if it should ever fail.

- DCHECK(result == WAIT_OBJECT_0) << "WaitForSingleObject failed";

+ DCHECK_EQ(WAIT_OBJECT_0, result) << "WaitForSingleObject failed";

return result == WAIT_OBJECT_0;

}