base/pickle.h - Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/pickle.h

Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Updating to follow EXPECTED, ACTUAL pattern on DCHECK_EQ() Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/pickle.h

diff --git a/base/pickle.h b/base/pickle.h

index ad08b7c0af0156131120bc0c875412705402d31d..305bef47648300c8addd207b6326d26aac717184 100644

--- a/base/pickle.h

+++ b/base/pickle.h

@@ -143,12 +143,12 @@ class Pickle {

// to the Pickle constructor.

template <class T>

T* headerT() {

- DCHECK(sizeof(T) == header_size_);

+ DCHECK_EQ(sizeof(T), header_size_);

Peter Kasting 2011/02/28 21:42:13 Nit: I think the order here should be reversed

KushalP 2011/02/28 21:54:06 Done.

return static_cast<T*>(header_);

}

template <class T>

const T* headerT() const {

- DCHECK(sizeof(T) == header_size_);

+ DCHECK_EQ(sizeof(T), header_size_);

return static_cast<const T*>(header_);

}

« no previous file with comments | « base/message_pump_win.cc ('k') | base/platform_file_posix.cc » ('j') | no next file with comments »