More DCHECK() updates. A mixture of _EQ and _GE.

base/platform_file_posix.cc

Index: base/platform_file_posix.cc
diff --git a/base/platform_file_posix.cc b/base/platform_file_posix.cc
index 38989c6bf41cddcf5b961b31cbcbfc6782df5d9d..266fa5a4b0646515bc03b032df6ee6f26d5edb35 100644
--- a/base/platform_file_posix.cc
+++ b/base/platform_file_posix.cc
@@ -65,7 +65,7 @@ PlatformFile CreatePlatformFile(const FilePath& name, int flags,
     open_flags |= O_TRUNC;
   }
 
-  DCHECK(O_RDONLY == 0);
+  DCHECK_EQ(O_RDONLY, 0U);

[willchan no longer on Chromium, 2011/02/21 23:17:20]

Strange. O_RDONLY is a constant. Why do we have a runtime assertion to make sure
two constants are equal?

Perhaps we should use a COMPILE_ASSERT(O_RDONLY == 0, O_RDONLY_must_equal_zero);
compile-time assertion instead.

[KushalP, 2011/02/22 00:57:29]

Sure, I'll look into it.

Isn't the second argument supposed to be a string message to be thrown and not
another variable?

On 2011/02/21 23:17:20, willchan wrote:

 
   int descriptor = open(name.value().c_str(), open_flags, S_IRUSR | S_IWUSR);