More DCHECK() updates. A mixture of _EQ and _GE.

base/platform_file_posix.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/platform_file.h"
 
 #include <fcntl.h>
 #include <errno.h>
 #include <sys/stat.h>
 
@@ skipping 47 matching lines @@
              !(flags & PLATFORM_FILE_WRITE_ATTRIBUTES) &&
              !(flags & PLATFORM_FILE_OPEN_ALWAYS)) {
     NOTREACHED();
   }
 
   if (flags & PLATFORM_FILE_TRUNCATE) {
     DCHECK(flags & PLATFORM_FILE_WRITE);
     open_flags |= O_TRUNC;
   }
 
-  DCHECK(O_RDONLY == 0);
+  DCHECK_EQ(O_RDONLY, 0U);

[willchan no longer on Chromium, 2011/02/21 23:17:20]

Strange. O_RDONLY is a constant. Why do we have a runtime assertion to make sure
two constants are equal?

Perhaps we should use a COMPILE_ASSERT(O_RDONLY == 0, O_RDONLY_must_equal_zero);
compile-time assertion instead.

[KushalP, 2011/02/22 00:57:29]

Sure, I'll look into it.

Isn't the second argument supposed to be a string message to be thrown and not
another variable?

On 2011/02/21 23:17:20, willchan wrote:

 
   int descriptor = open(name.value().c_str(), open_flags, S_IRUSR | S_IWUSR);
 
   if (flags & PLATFORM_FILE_OPEN_ALWAYS) {
     if (descriptor > 0) {
       if (created)
         *created = false;
     } else {
       open_flags |= O_CREAT;
       if (flags & PLATFORM_FILE_EXCLUSIVE_READ ||
@@ skipping 110 matching lines @@
   info->is_directory = S_ISDIR(file_info.st_mode);
   info->is_symbolic_link = S_ISLNK(file_info.st_mode);
   info->size = file_info.st_size;
   info->last_modified = base::Time::FromTimeT(file_info.st_mtime);
   info->last_accessed = base::Time::FromTimeT(file_info.st_atime);
   info->creation_time = base::Time::FromTimeT(file_info.st_ctime);
   return true;
 }
 
 }  // namespace base