base/i18n/bidi_line_iterator.cc - Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/bidi_line_iterator.cc

Issue 6469070: More DCHECK() updates. A mixture of _EQ and _GE. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/i18n/bidi_line_iterator.cc

diff --git a/base/i18n/bidi_line_iterator.cc b/base/i18n/bidi_line_iterator.cc

index 3222a3ad136dadf0bd08d70aa389ff72974dce93..5e9cd11c23eb96271be485369d840a49c8dc3c5c 100644

--- a/base/i18n/bidi_line_iterator.cc

+++ b/base/i18n/bidi_line_iterator.cc

@@ -22,7 +22,7 @@ BiDiLineIterator::~BiDiLineIterator() {

bool BiDiLineIterator::Open(const string16& text,

bool right_to_left,

bool url) {

- DCHECK(bidi_ == NULL);

+ DCHECK(!bidi_);

UErrorCode error = U_ZERO_ERROR;

bidi_ = ubidi_openSized(static_cast<int>(text.length()), 0, &error);

if (U_FAILURE(error))