Merge 75412 - Add product-specific flags to the rename command in the registr...

Merge 75412 - Add product-specific flags to the rename command in the registry.  This fixes a regression that prevented in-place upgrades of Chrome Frame from working.

BUG=73329
TEST=Follow the steps in the bug.  Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame".

Review URL: http://codereview.chromium.org/6541029

TBR=grt@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75502

[grt (UTC plus 2), 2011-02-19 05:08:15]

Since 648 doesn't have the refactor, this change isn't identical to
http://codereview.chromium.org/6541029/, but it should be functionally
equivalent.  I've verified locally that the rename command is correct for both
GCF and Chrome SxS when an in-use update takes place.

[tommi (sloooow) - chröme, 2011-02-19 05:20:37]

lgtm.

appending the uninstall flags is not ideal but fine in this case since it's a
branch specific fix.

[grt (UTC plus 2), 2011-02-19 05:28:07]

On 2011/02/19 05:20:37, tommi wrote:
> lgtm.
> 
> appending the uninstall flags is not ideal but fine in this case since it's a
> branch specific fix.

Just to clarify: the implementations of "AppendUninstallCommandLineFlags" in the
BrowserDistribution classes don't add --uninstall and the like to the
command-line.  Rather, they add only the distribution-specific flags (e.g.,
--chrome-sxs, --chrome-frame, etc).  Is there anything other than the method
name that gives you pause?

[tommi (sloooow) - chröme, 2011-02-19 05:32:38]

sorry I wasn't clear, it's just the name and reading the code that's not
ideal.  I know what the implementations do.

On Sat, Feb 19, 2011 at 12:28 AM, <grt@chromium.org> wrote:

> On 2011/02/19 05:20:37, tommi wrote:
>
>> lgtm.
>>
>
>  appending the uninstall flags is not ideal but fine in this case since
>> it's a
>> branch specific fix.
>>
>
> Just to clarify: the implementations of "AppendUninstallCommandLineFlags"
> in the
> BrowserDistribution classes don't add --uninstall and the like to the
> command-line.  Rather, they add only the distribution-specific flags (e.g.,
> --chrome-sxs, --chrome-frame, etc).  Is there anything other than the
> method
> name that gives you pause?
>
>
> http://codereview.chromium.org/6469069/
>

[grt (UTC plus 2), 2011-02-19 05:36:08]

On 2011/02/19 05:32:38, tommi wrote:
> sorry I wasn't clear, it's just the name and reading the code that's not
> ideal.  I know what the implementations do.

Groovy.  Go to sleep.

I'll wait for Robert's ack before committing.  Either of you: let me know if
you'd like me to add a comment at the call to AppendUninstallCommandLineFlags
that explains why it is used here.

Thanks, Tommi.

[tommi (sloooow) - chröme, 2011-02-19 05:39:58]

lgtm++

yeah, a little comment would be nice :)

On Sat, Feb 19, 2011 at 12:36 AM, <grt@chromium.org> wrote:

> On 2011/02/19 05:32:38, tommi wrote:
>
>> sorry I wasn't clear, it's just the name and reading the code that's not
>> ideal.  I know what the implementations do.
>>
>
> Groovy.  Go to sleep.
>
> I'll wait for Robert's ack before committing.  Either of you: let me know
> if
> you'd like me to add a comment at the call to
> AppendUninstallCommandLineFlags
> that explains why it is used here.
>
> Thanks, Tommi.
>
>
> http://codereview.chromium.org/6469069/
>

[grt (UTC plus 2), 2011-02-19 12:06:15]

Comment added.

[robertshield, 2011-02-19 17:18:07]

LGTM