Add product-specific flags to the rename command in the registry. This fixes...

Add product-specific flags to the rename command in the registry.  This fixes a regression that prevented in-place upgrades of Chrome Frame from working.

BUG=73329
TEST=Follow the steps in the bug.  Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75412

[grt (UTC plus 2), 2011-02-18 18:20:33]

This also propagates --verbose-logging to the rename command.  Yay.  Note that
this doesn't fix the crasher we experience if the rename fails (if, for example,
%TMP% is on another volume).

[tommi (sloooow) - chröme, 2011-02-18 18:23:37]

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (left):

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:438:
rename.AppendSwitch(installer::switches::kChromeSxS);
why are we removing the sxs and multi-install switches?

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:438:
rename.AppendSwitch(switches::kVerboseLogging);
nice

[grt (UTC plus 2), 2011-02-18 18:30:06]

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (left):

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:438:
rename.AppendSwitch(installer::switches::kChromeSxS);
On 2011/02/18 18:23:38, tommi wrote:
> why are we removing the sxs and multi-install switches?

They're added by the ProductOperations subclasses.  We already had the code to
do the product-specific flags for the uninstall command, so we can reuse that
here.

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:438:
rename.AppendSwitch(switches::kVerboseLogging);
On 2011/02/18 18:23:38, tommi wrote:
> nice

Thanks.

[robertshield, 2011-02-18 18:31:57]

LGTM

[tommi (sloooow) - chröme, 2011-02-18 18:41:12]

lgtm

On Fri, Feb 18, 2011 at 1:30 PM, <grt@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
> File chrome/installer/setup/install_worker.cc (left):
>
>
>
http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
> chrome/installer/setup/install_worker.cc:438:
> rename.AppendSwitch(installer::switches::kChromeSxS);
> On 2011/02/18 18:23:38, tommi wrote:
>
>> why are we removing the sxs and multi-install switches?
>>
>
> They're added by the ProductOperations subclasses.  We already had the
> code to do the product-specific flags for the uninstall command, so we
> can reuse that here.
>
>
>
>
http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
> File chrome/installer/setup/install_worker.cc (right):
>
>
>
http://codereview.chromium.org/6541029/diff/1/chrome/installer/setup/install_...
> chrome/installer/setup/install_worker.cc:438:
> rename.AppendSwitch(switches::kVerboseLogging);
> On 2011/02/18 18:23:38, tommi wrote:
>
>> nice
>>
>
> Thanks.
>
>
> http://codereview.chromium.org/6541029/
>

[grt (UTC plus 2), 2011-02-18 19:35:04]

I've added checks to the validator for product-specific flags in the rename
command.  PTAL.

[tommi (sloooow) - chröme, 2011-02-18 19:40:52]

lgtm

[robertshield, 2011-02-18 19:41:11]

looks a'ight