Issue 6469044: The bookmark folder menus look bad when squeezed up against the bottom of a s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469044: The bookmark folder menus look bad when squeezed up against the bottom of a s... (Closed)

Created:
9 years, 10 months ago by mafv

Modified:
9 years, 6 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Second try - didn't rev the unit test in the first version of this fix. The bookmark folder menus look bad when squeezed up against the bottom of a screen. Detect this case and automatically switch to showing the menu above the button in this case. BUG=69996 TEST=bookmark_bar_folder_controller_unittest.mm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75342 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75428

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -8 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View	4 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

mafv

Previous version of this got backed out because I forgot to include required unit test ...

9 years, 10 months ago (2011-02-18 03:09:13 UTC) #1

LGTM