Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Issue 6469044: The bookmark folder menus look bad when squeezed up against the bottom of a s... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
===================================================================
--- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm (revision 75353)
+++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm (working copy)
@@ -256,7 +256,7 @@
parentController:nil
barController:bar_]);
[bbfc window];
- NSPoint pt = [bbfc windowTopLeftForWidth:0]; // screen coords
+ NSPoint pt = [bbfc windowTopLeftForWidth:0 height:100]; // screen coords
NSPoint buttonOriginInScreen =
[[parentButton window]
convertBaseToScreen:[parentButton
@@ -268,8 +268,8 @@
bookmarks::kBookmarkMenuOverlap+1);
// Make sure we see the window shift left if it spills off the screen
- pt = [bbfc windowTopLeftForWidth:0];
- NSPoint shifted = [bbfc windowTopLeftForWidth:9999999];
+ pt = [bbfc windowTopLeftForWidth:0 height:100];
+ NSPoint shifted = [bbfc windowTopLeftForWidth:9999999 height:100];
EXPECT_LT(shifted.x, pt.x);
// If parent is a BookmarkBarFolderController, grow right.
@@ -279,7 +279,7 @@
parentController:bbfc.get()
barController:bar_]);
[bbfc2 window];
- pt = [bbfc2 windowTopLeftForWidth:0];
+ pt = [bbfc2 windowTopLeftForWidth:0 height:100];
// We're now overlapping the window a bit.
EXPECT_EQ(pt.x, NSMaxX([[bbfc.get() window] frame]) -
bookmarks::kBookmarkMenuOverlap);
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698