Issue 6465006: Return bad exit code when we fail to generate an update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6465006: Return bad exit code when we fail to generate an update. (Closed)

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

Return bad exit code when we fail to generate an update. Change-Id: Ib3dabf88fff5518b6d95d549aac7d463d55bad87 BUG=chromium-os:11849 TEST=Ran cros_generate_update_payload with good and bad private keys and get 0 and 1 respectively back. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c7c19cd

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	generate_delta_main.cc	View		1 chunk	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 10 months ago (2011-02-09 00:38:10 UTC) #2

LGTM w/ a nit.

http://codereview.chromium.org/6465006/diff/1/generate_delta_main.cc
File generate_delta_main.cc (right):

http://codereview.chromium.org/6465006/diff/1/generate_delta_main.cc#newcode198
generate_delta_main.cc:198: } else {
Prefer getting rid of the else...

Expand Messages | Collapse Messages