Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: generate_delta_main.cc

Issue 6465006: Return bad exit code when we fail to generate an update. (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: generate_delta_main.cc
diff --git a/generate_delta_main.cc b/generate_delta_main.cc
index 0f791e0b509dfb6cbbb16ead976e394df4789fdc..1a7a98ef37d6794af8092bf6a6fbc0afd6942db9 100644
--- a/generate_delta_main.cc
+++ b/generate_delta_main.cc
@@ -186,16 +186,18 @@ int Main(int argc, char** argv) {
LOG(FATAL) << "old_dir or new_dir not directory";
}
}
- DeltaDiffGenerator::GenerateDeltaUpdateFile(FLAGS_old_dir,
+ if (DeltaDiffGenerator::GenerateDeltaUpdateFile(FLAGS_old_dir,
FLAGS_old_image,
FLAGS_new_dir,
FLAGS_new_image,
FLAGS_old_kernel,
FLAGS_new_kernel,
FLAGS_out_file,
- FLAGS_private_key);
-
- return 0;
+ FLAGS_private_key)) {
+ return 0;
+ } else {
petkov 2011/02/09 00:38:10 Prefer getting rid of the else...
+ return 1;
+ }
}
} // namespace {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698