Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6462015: Cleanup more test code. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Cleanup more test code. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74328

Patch Set 1 #

Patch Set 2 : Copyright update #

Total comments: 1

Patch Set 3 : fix for thestig / wtf windows #

Patch Set 4 : wtf windows is this me #

Patch Set 5 : wtf windows is this me #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1328 lines, -775 lines) Patch
M chrome/browser/sessions/session_service_test_helper.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/test/live_sync/live_bookmarks_sync_test.h View 1 5 chunks +36 lines, -188 lines 0 comments Download
A chrome/test/live_sync/live_bookmarks_sync_test.cc View 1 chunk +262 lines, -0 lines 0 comments Download
M chrome/test/live_sync/live_sessions_sync_test.h View 5 chunks +35 lines, -261 lines 0 comments Download
A chrome/test/live_sync/live_sessions_sync_test.cc View 1 1 chunk +312 lines, -0 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/live_sync/many_client_live_bookmarks_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/many_client_live_passwords_sync_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/live_sync/many_client_live_preferences_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/multiple_client_live_passwords_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/multiple_client_live_sessions_sync_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/live_sync/single_client_live_bookmarks_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/single_client_live_extensions_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/single_client_live_passwords_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/single_client_live_preferences_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/single_client_live_sessions_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/single_client_live_themes_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/two_client_live_autofill_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/two_client_live_passwords_sync_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/live_sync/two_client_live_preferences_sync_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/two_client_live_sessions_sync_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/live_sync/two_client_live_themes_sync_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/sync/engine/test_directory_setter_upper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/sync/engine/test_directory_setter_upper.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/webdriver/automation.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/webdriver/automation.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/command.h View 1 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/test/webdriver/commands/command.cc View 1 2 chunks +24 lines, -1 line 0 comments Download
M chrome/test/webdriver/commands/find_element_commands.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/test/webdriver/commands/find_element_commands.cc View 1 4 chunks +18 lines, -1 line 0 comments Download
M chrome/test/webdriver/keymap.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/webdriver/keymap.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/webdriver/session.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M chrome/test/webdriver/session.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/webdriver/session_manager.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/webdriver/session_manager.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M webkit/mocks/mock_webframe.h View 1 3 chunks +102 lines, -243 lines 0 comments Download
A webkit/mocks/mock_webframe.cc View 1 chunk +393 lines, -0 lines 0 comments Download
M webkit/mocks/mock_weburlloader.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
A webkit/mocks/mock_weburlloader.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
9 years, 10 months ago (2011-02-09 01:38:11 UTC) #1
Lei Zhang
http://codereview.chromium.org/6462015/diff/2001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/6462015/diff/2001/chrome/chrome_tests.gypi#newcode87 chrome/chrome_tests.gypi:87: 'browser/sessions/session_service_test_helper.cc', nit: can you move browser/tab_contents/test_tab_contents.* down while you're ...
9 years, 10 months ago (2011-02-09 01:56:36 UTC) #2
Lei Zhang
9 years, 10 months ago (2011-02-09 01:56:48 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698